Skip to content

ci: use test-base image for unit tests to fix sanitizers symbolization#100744

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:ci/unit-tests-sanitizers-symbolizer
Mar 26, 2026
Merged

ci: use test-base image for unit tests to fix sanitizers symbolization#100744
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:ci/unit-tests-sanitizers-symbolizer

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 25, 2026

fasttest does not have llvm package, while test-base does

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100702&sha=latest&name_0=PR&name_1=Unit+tests+%28asan_ubsan%29

fasttest does not have llvm package, while test-base does
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 25, 2026

Workflow [PR], commit [bbca09c]

Summary:


AI Review

Summary

This PR updates the UNITTEST CI job to run in the clickhouse/test-base image instead of clickhouse/fasttest, so sanitizer reports can be symbolized (LLVM tools are available in test-base). The change is small, targeted, and consistent with the stated motivation; I did not find correctness, safety, or rollout issues in the code diff.

ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 25, 2026
@alexey-milovidov alexey-milovidov self-assigned this Mar 26, 2026
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Mar 26, 2026
Merged via the queue into ClickHouse:master with commit 6b081e7 Mar 26, 2026
153 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants