Skip to content

Fix LDAP integration test port conflict in parallel CI runs#100733

Merged
alexey-milovidov merged 1 commit intomasterfrom
ldap-test-flaky
Mar 25, 2026
Merged

Fix LDAP integration test port conflict in parallel CI runs#100733
alexey-milovidov merged 1 commit intomasterfrom
ldap-test-flaky

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 25, 2026

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 25, 2026

Workflow [PR], commit [6cf0dcb]

Summary:


AI Review

Summary

This PR updates the integration test cluster helper to allocate a unique host port for LDAP (LDAP_EXTERNAL_PORT) from the shared PortPool instead of always using 1389, which addresses parallel CI port conflicts for LDAP-enabled integration tests. The change is small, consistent with existing dynamic port allocation patterns in the same file, and I did not find correctness, safety, or performance issues.

ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-ci label Mar 25, 2026
@alexey-milovidov alexey-milovidov self-assigned this Mar 25, 2026
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Mar 25, 2026
Merged via the queue into master with commit 34301c5 Mar 25, 2026
153 checks passed
@alexey-milovidov alexey-milovidov deleted the ldap-test-flaky branch March 25, 2026 20:28
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants