Skip to content

Fix flaky test 04004_integral_col_comparison_with_float_key_condition#100214

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
nihalzp:fix-flaky-test-04004_integral_col_comparison_with_float_key_condition
Mar 20, 2026
Merged

Fix flaky test 04004_integral_col_comparison_with_float_key_condition#100214
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
nihalzp:fix-flaky-test-04004_integral_col_comparison_with_float_key_condition

Conversation

@nihalzp
Copy link
Copy Markdown
Member

@nihalzp nihalzp commented Mar 20, 2026

The issue was that some low value of index_granularity_bytes lowered the size of granules, causing the queries fail. The test depends on exact granularity.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Closes #100129

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 20, 2026

Workflow [PR], commit [b2c71b7]

Summary:


AI Review

Summary

This PR stabilizes 04004_integral_col_comparison_with_float_key_condition by explicitly setting index_granularity_bytes = 10485760 in all test tables, so the test no longer depends on ambient granule-size behavior. The change is scoped to test SQL/reference files, is consistent across all table definitions in the test, and I did not find correctness or safety issues.

ClickHouse Rules

Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time

Final Verdict

Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-ci label Mar 20, 2026
@SmitaRKulkarni SmitaRKulkarni self-assigned this Mar 20, 2026
@nihalzp nihalzp enabled auto-merge March 20, 2026 23:15
@nihalzp nihalzp disabled auto-merge March 20, 2026 23:15
@alexey-milovidov alexey-milovidov merged commit 48a756b into ClickHouse:master Mar 20, 2026
151 of 152 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: 04004_integral_col_comparison_with_float_key_condition

4 participants