-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Performance tests are unstable #78555
Copy link
Copy link
Closed
Labels
close in a month if not activeThis will be closed in case of no informationThis will be closed in case of no informationcomp-ci-infrastructureCI/CD pipelines (GitHub Actions, CI scripts, runners).CI/CD pipelines (GitHub Actions, CI scripts, runners).
Metadata
Metadata
Assignees
Labels
close in a month if not activeThis will be closed in case of no informationThis will be closed in case of no informationcomp-ci-infrastructureCI/CD pipelines (GitHub Actions, CI scripts, runners).CI/CD pipelines (GitHub Actions, CI scripts, runners).
Type
Fields
Give feedbackNo fields configured for issues without a type.
I've seen lots of time when there should be zero difference in performance tests, while it shows unstable queries, i.e.:
Possible issues from the top of my head (from likely to unlikely):
very unlikely, but ensure that there is only one numa node on the CI workersonly 1CREATE TABLE ... ENGINE = File()toINSERT INTO FUNCTION file()(i.e.number_formatting_formats.xml)after refactoringzzz-perf-comparison-tweaks-config.xmlis not used (sigh)Also some other issues that does not looks good:
Referenced issues:
Some observations/cases:
MemorySharedis 2x bigger - https://s3.amazonaws.com/clickhouse-test-reports/PRs/82441/308985c016e559f5f367261a5e5ea20e0c52cc68//performance_comparison_amd_release_master_head_1_3/report.html (due to debug symbols likely)Old issues: