Skip to content

clickhouse creates lots of system log tables if config storage settings for system log table #34929

@xuyatian

Description

@xuyatian

Describe what's wrong
clickhouse creates lots of system log tables if config storage settings for system log table

Does it reproduce on recent release?
22.1

How to reproduce

  • Which ClickHouse server version to use
    22.1
  • Non-default settings, if any
    config query_log table as below:
query_log:
  partition_by:
    "@remove": 1
  engine: |
    ENGINE = MergeTree PARTITION BY (event_date)
    ORDER BY (event_time)
    TTL event_date + INTERVAL 14 DAY DELETE
    SETTINGS ttl_only_drop_parts=1

Expected behavior
clickhouse should not create new system log tables if the table is not changed.

Error message and/or stacktrace
2022.02.26 19:53:28.039097 [ 1197451 ] {} SystemLog (system.query_log): Existing table system.query_log for system log has obsolete or different structure. Renaming it to query_log_13.
Old: CREATE TABLE system.query_log (....) ENGINE = MergeTree PARTITION BY event_date ORDER BY event_time TTL event_date + toIntervalDay(14)
New: CREATE TABLE system.query_log (....) ENGINE = MergeTree PARTITION BY event_date ORDER BY event_time TTL event_date + toIntervalDay(14) SETTINGS ttl_only_drop_parts = 1

Additional context
in this commit 5fafeea, v3: SETTINGS of MergeTree in old CREATE TABLE query is reset before comparing with new create query.

Metadata

Metadata

Labels

bugConfirmed user-visible misbehaviour in official releasecomp-ttlTTL rules and TTL merges (moving/recompressing/rolling-up/deleting parts).

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions