Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ClickHouse/ClickHouse
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: azat/ClickHouse
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: next
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 18 files changed
  • 3 contributors

Commits on Feb 11, 2024

  1. Configure keeper for perf tests

    Signed-off-by: Azat Khuzhin <[email protected]>
    azat committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2a07d95 View commit details
    Browse the repository at this point in the history
  2. Improve performance of SELECTs with active mutations

    getAlterMutationCommandsForPart() can be a hot path for query execution
    when there are pending mutations.
    
    - LOG_TEST - it is not only check one bool, but actually a bunch of
      atomics as well.
    
    - Return std::vector over std::map (map is not required there) - no
      changes in performance.
    
    - Copy only RENAME_COLUMN (since only this mutation is required by
      AlterConversions).
    
    And here are results:
    
    run|result
    -|-
    SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
    SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
    SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
    SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982
    
    But there are still room for improvements, at least MergeTree engines
    could implement getStorageSnapshotForQuery().
    
    Signed-off-by: Azat Khuzhin <[email protected]>
    azat committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1253a73 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Add AlterConversions::supportsMutationCommandType(), flatten vector<v…

    …ector<MutationCommand>>
    al13n321 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    3c6a2c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    99ec722 View commit details
    Browse the repository at this point in the history
  2. Updated implementation

    kitaisreal committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6ac65e9 View commit details
    Browse the repository at this point in the history
  3. Fixed build

    kitaisreal committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2886831 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bfa84f0 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'u/pr/60139' into next

    * u/pr/60139:
      Fix data race
    azat committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6b5a6f2 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'u/pr/59531' into next

    * u/pr/59531:
      Work around what appears to be a clang static analysis bug
      Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>
      Improve performance of SELECTs with active mutations
      Configure keeper for perf tests
    azat committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    397ad88 View commit details
    Browse the repository at this point in the history
  7. Merge remote-tracking branch 'u/pr/60041' into next

    * u/pr/60041:
      Fixed build
      Updated implementation
      PartsSplitter invalid ranges for the same part
    azat committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ca116a3 View commit details
    Browse the repository at this point in the history
Loading