add comment

vdimir · vdimir · commit f7261443fee5 · 2025-06-25T07:46:15.000Z
diff --git a/src/Analyzer/Resolve/QueryAnalyzer.cpp b/src/Analyzer/Resolve/QueryAnalyzer.cpp
@@ -2267,8 +2267,8 @@ ProjectionNames QueryAnalyzer::resolveMatcher(QueryTreeNodePtr & matcher_node, I
     {
         /** If we are resolving matcher came from the result of JOIN and `join_use_nulls` is set,
           * we need to convert joined column type to Nullable.
-          * We are taking the nearest JoinNode to check to which table column belongs,
-          * because for LEFT/RIGHT join, we convert only the corresponding side.
+          * We are checking all registered_table_expression_nodes which contains all table expressions that are used to resolve matcher.
+          * If it's on null side, we need to convert column type to Nullable.
           */
         for (const auto & table_expression : scope.registered_table_expression_nodes)
         {

Original file line number	Diff line number	Diff line change
`@@ -2267,8 +2267,8 @@ ProjectionNames QueryAnalyzer::resolveMatcher(QueryTreeNodePtr & matcher_node, I`
`2267`	`2267`	`{`
`2268`	`2268`	/** If we are resolving matcher came from the result of JOIN and `join_use_nulls` is set,
`2269`	`2269`	`* we need to convert joined column type to Nullable.`
`2270`		`- * We are taking the nearest JoinNode to check to which table column belongs,`
`2271`		`- * because for LEFT/RIGHT join, we convert only the corresponding side.`
	`2270`	`+ * We are checking all registered_table_expression_nodes which contains all table expressions that are used to resolve matcher.`
	`2271`	`+ * If it's on null side, we need to convert column type to Nullable.`
`2272`	`2272`	`*/`
`2273`	`2273`	`for (const auto & table_expression : scope.registered_table_expression_nodes)`
`2274`	`2274`	`{`