Remove unnecessary const hinted by clang-tidy

pamarcos · pamarcos · commit f6b19e143a4e · 2024-04-27T09:30:51.000+02:00
Removing the reference for Index makes the const unnecessary.
Constness for it is still preserved correctly because Columns
are inmutable pointers to IColumn.
diff --git a/src/Storages/MergeTree/IMergeTreeDataPart.cpp b/src/Storages/MergeTree/IMergeTreeDataPart.cpp
@@ -340,7 +340,7 @@ IMergeTreeDataPart::~IMergeTreeDataPart()
 }
 
 
-const IMergeTreeDataPart::Index IMergeTreeDataPart::getIndex() const
+IMergeTreeDataPart::Index IMergeTreeDataPart::getIndex() const
 {
     std::scoped_lock lock(index_mutex);
     if (!index_loaded)
diff --git a/src/Storages/MergeTree/IMergeTreeDataPart.h b/src/Storages/MergeTree/IMergeTreeDataPart.h
@@ -367,7 +367,7 @@ class IMergeTreeDataPart : public std::enable_shared_from_this<IMergeTreeDataPar
     /// Version of part metadata (columns, pk and so on). Managed properly only for replicated merge tree.
     int32_t metadata_version;
 
-    const Index getIndex() const;
+    Index getIndex() const;
     void setIndex(Index index_);
     void unloadIndex();
 
diff --git a/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp b/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
@@ -999,7 +999,6 @@ MarkRanges MergeTreeDataSelectExecutor::markRangesFromPKRange(
 
     size_t marks_count = part->index_granularity.getMarksCount();
     const auto & index = part->getIndex();
-
     if (marks_count == 0)
         return res;
 

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ IMergeTreeDataPart::~IMergeTreeDataPart()`
`340`	`340`	`}`
`341`	`341`
`342`	`342`
`343`		`-const IMergeTreeDataPart::Index IMergeTreeDataPart::getIndex() const`
	`343`	`+IMergeTreeDataPart::Index IMergeTreeDataPart::getIndex() const`
`344`	`344`	`{`
`345`	`345`	`std::scoped_lock lock(index_mutex);`
`346`	`346`	`if (!index_loaded)`