Skip to content

Commit ee5b389

Browse files
committed
tests: better fix for 03706_statistics_preserve_checksums_on_mutations
The previous bot attempt was to set serialization_info_version='basic', while this is OK, it is not transparent what was the problem. Let's instead set map_serialization_version='basic', map_serialization_version_for_zero_level_parts='basic', since those was causes the difference: File: .server/data/default/mt/all_1_1_0_2/serialization.json {"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"nullable":1,"string":0},"version":1} File: .server/data/default/mt/all_1_1_0/serialization.json {"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"map":1,"nullable":1,"string":0},"version":1}
1 parent 4682d3e commit ee5b389

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

tests/queries/0_stateless/03706_statistics_preserve_checksums_on_mutations.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@ create table mt (key Int, value String) engine=MergeTree() order by key settings
1414
min_bytes_for_wide_part=0,
1515
-- otherwise sparse info will be different, since for INSERTs the sparse ratio is calculated for the whole block, while for mutations for each granula (FIXME?)
1616
ratio_of_defaults_for_sparse_serialization=1,
17-
-- Pin serialization_info_version to 'basic': with 'with_types' the INSERT and mutation
18-
-- paths produce different serialization.json content (the mutation always uses the table's
19-
-- stored settings while the INSERT path may produce different serialization info metadata),
20-
-- causing checksum mismatches that are not actual data corruption.
21-
serialization_info_version='basic',
17+
map_serialization_version='basic',
18+
map_serialization_version_for_zero_level_parts='basic',
2219
-- This uncovers the bug
2320
auto_statistics_types='uniq,minmax,countmin,tdigest'
2421
;

0 commit comments

Comments
 (0)