fix memory leak in bzip2

yakov-olkhovskiy · yakov-olkhovskiy · commit d5d060a17e4b · 2024-01-17T12:53:37.000Z
diff --git a/src/IO/Bzip2WriteBuffer.cpp b/src/IO/Bzip2WriteBuffer.cpp
@@ -14,7 +14,10 @@ namespace ErrorCodes
     extern const int BZIP2_STREAM_ENCODER_FAILED;
 }
 
-Bzip2WriteBuffer::~Bzip2WriteBuffer() = default;
+Bzip2WriteBuffer::~Bzip2WriteBuffer()
+{
+    BZ2_bzCompressEnd(&stream);
+}
 
 void Bzip2WriteBuffer::nextImpl()
 {
@@ -87,11 +90,6 @@ void Bzip2WriteBuffer::finalizeBefore()
     while (true);
 }
 
-void Bzip2WriteBuffer::finalizeAfter()
-{
-    BZ2_bzCompressEnd(&stream);
-}
-
 }
 
 #endif
diff --git a/src/IO/Bzip2WriteBuffer.h b/src/IO/Bzip2WriteBuffer.h
@@ -48,7 +48,6 @@ class Bzip2WriteBuffer : public WriteBufferWithOwnMemoryDecorator
     void nextImpl() override;
 
     void finalizeBefore() override;
-    void finalizeAfter() override;
 
     bz_stream stream;
     bool compress_empty = true;

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,10 @@ namespace ErrorCodes`
`14`	`14`	`extern const int BZIP2_STREAM_ENCODER_FAILED;`
`15`	`15`	`}`
`16`	`16`
`17`		`-Bzip2WriteBuffer::~Bzip2WriteBuffer() = default;`
	`17`	`+Bzip2WriteBuffer::~Bzip2WriteBuffer()`
	`18`	`+{`
	`19`	`+ BZ2_bzCompressEnd(&stream);`
	`20`	`+}`
`18`	`21`
`19`	`22`	`void Bzip2WriteBuffer::nextImpl()`
`20`	`23`	`{`
`@@ -87,11 +90,6 @@ void Bzip2WriteBuffer::finalizeBefore()`
`87`	`90`	`while (true);`
`88`	`91`	`}`
`89`	`92`
`90`		`-void Bzip2WriteBuffer::finalizeAfter()`
`91`		`-{`
`92`		`- BZ2_bzCompressEnd(&stream);`
`93`		`-}`
`94`		`-`
`95`	`93`	`}`
`96`	`94`
`97`	`95`	`#endif`