Skip to content

Commit d0dec34

Browse files
authored
Merge pull request #89919 from ClickHouse/revert-89207-fix_ytsaurus_intg_tests_ports_v2
Revert "Fix ports conflicts for ytsaurus integration tests v2 "
2 parents 2672ba9 + 3d0a9cf commit d0dec34

File tree

2 files changed

+1
-26
lines changed

2 files changed

+1
-26
lines changed

tests/integration/compose/docker_compose_ytsaurus.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,4 @@ services:
1010
YT_PROXY: ytsaurus_backend1:${YTSAURUS_PROXY_PORT}
1111
ports:
1212
- ${YTSAURUS_PROXY_PORT}:${YTSAURUS_PROXY_PORT}
13-
entrypoint: yt_local start --proxy-port ${YTSAURUS_PROXY_PORT}
14-
--local-cypress-dir /var/lib/yt/local-cypress
15-
--ytserver-all-path /usr/bin/ytserver-all
16-
--sync --fqdn ytsaurus_backend1
17-
--proxy-config '{coordinator={public_fqdn="ytsaurus_backend1:${YTSAURUS_PROXY_PORT}"}}'
18-
--node-count 1
19-
--queue-agent-count 1
20-
--address-resolver-config '{enable_ipv4=%true;enable_ipv6=%false;}'
21-
--listen-port-pool ${YTSAURUS_INTERNAL_PORTS_LIST}
22-
--native-client-supported
23-
--id primary -c '{name=query-tracker}'
24-
--enable-auth
25-
--create-admin-user
13+
entrypoint: yt_local start --proxy-port ${YTSAURUS_PROXY_PORT} --local-cypress-dir /var/lib/yt/local-cypress --ytserver-all-path /usr/bin/ytserver-all --sync --fqdn ytsaurus_backend1 --proxy-config '{coordinator={public_fqdn="ytsaurus_backend1:${YTSAURUS_PROXY_PORT}"}}' --node-count 1 --queue-agent-count 1 --address-resolver-config '{enable_ipv4=%true;enable_ipv6=%false;}' --port-range-start 50000 --native-client-supported --id primary -c '{name=query-tracker}' --enable-auth --create-admin-user

tests/integration/helpers/cluster.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -865,8 +865,6 @@ def __init__(
865865
self.prometheus_remote_read_handlers = []
866866

867867
self._ytsaurus_port = None
868-
self._ytsaurus_internal_ports_list = None
869-
self.ytsaurus_internal_ports_list_size = 20
870868

871869
self.docker_client: docker.DockerClient = None
872870
self.is_up = False
@@ -987,14 +985,6 @@ def ytsaurus_port(self):
987985
self._ytsaurus_port = self.port_pool.get_port()
988986
return self._ytsaurus_port
989987

990-
@property
991-
def ytsaurus_internal_ports_list(self):
992-
if not self._ytsaurus_internal_ports_list:
993-
self._ytsaurus_internal_ports_list = []
994-
for _ in range(self.ytsaurus_internal_ports_list_size):
995-
self._ytsaurus_internal_ports_list.append(self.port_pool.get_port())
996-
return self._ytsaurus_internal_ports_list
997-
998988
def print_all_docker_pieces(self):
999989
res_networks = subprocess.check_output(
1000990
f"docker network ls --filter name='{self.project_name}*'",
@@ -1763,9 +1753,6 @@ def setup_hive(self, instance, env_variables, docker_compose_yml_dir):
17631753
def setup_ytsaurus(self, instance, env_variables, docker_compose_yml_dir):
17641754
self.with_ytsaurus = True
17651755
env_variables["YTSAURUS_PROXY_PORT"] = str(self.ytsaurus_port)
1766-
env_variables["YTSAURUS_INTERNAL_PORTS_LIST"] = " ".join(
1767-
str(port) for port in self.ytsaurus_internal_ports_list
1768-
)
17691756

17701757
self.base_cmd.extend(
17711758
["--file", p.join(docker_compose_yml_dir, "docker_compose_ytsaurus.yml")]

0 commit comments

Comments
 (0)