Merge pull request #58748 from ClickHouse/imp-01600_parts

alexey-milovidov · web-flow · commit c2b2533f7682 · 2024-07-04T00:48:02.000Z
Return and fix 01600_parts_states_metrics_long test
diff --git a/tests/queries/0_stateless/01600_parts_states_metrics_long.reference b/tests/queries/0_stateless/01600_parts_states_metrics_long.reference
@@ -0,0 +1,4 @@
+1
+1
+1
+1
diff --git a/tests/queries/0_stateless/01600_parts_states_metrics_long.sh b/tests/queries/0_stateless/01600_parts_states_metrics_long.sh
@@ -0,0 +1,40 @@
+#!/usr/bin/env bash
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CURDIR"/../shell_config.sh
+
+# NOTE: database = $CLICKHOUSE_DATABASE is unwanted
+verify_sql="SELECT
+    (SELECT sumIf(value, metric = 'PartsActive'), sumIf(value, metric = 'PartsOutdated') FROM system.metrics)
+    = (SELECT sum(active), sum(NOT active) FROM
+    (SELECT active FROM system.parts UNION ALL SELECT active FROM system.projection_parts UNION ALL SELECT 1 FROM system.dropped_tables_parts))"
+
+# The query is not atomic - it can compare states between system.parts and system.metrics from different points in time.
+# So, there is inherent race condition. But it should get expected result eventually.
+# In case of test failure, this code will do infinite loop and timeout.
+verify()
+{
+    while true
+    do
+        result=$( $CLICKHOUSE_CLIENT -m --query="$verify_sql" )
+        [ "$result" = "1" ] && break
+        sleep 0.1
+    done
+    echo 1
+}
+
+$CLICKHOUSE_CLIENT --database_atomic_wait_for_drop_and_detach_synchronously=1 --query="DROP TABLE IF EXISTS test_table"
+$CLICKHOUSE_CLIENT --query="CREATE TABLE test_table(data Date) ENGINE = MergeTree  PARTITION BY toYear(data) ORDER BY data;"
+
+$CLICKHOUSE_CLIENT --query="INSERT INTO test_table VALUES ('1992-01-01')"
+verify
+
+$CLICKHOUSE_CLIENT --query="INSERT INTO test_table VALUES ('1992-01-02')"
+verify
+
+$CLICKHOUSE_CLIENT --query="OPTIMIZE TABLE test_table FINAL"
+verify
+
+$CLICKHOUSE_CLIENT --database_atomic_wait_for_drop_and_detach_synchronously=1 --query="DROP TABLE test_table"
+verify

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +1
 +1
 +1
 +1