Backport #94855 to 25.12: Add index out of range check in advanced shared data in JSON

robot-clickhouse · robot-clickhouse · commit 9feffb018367 · 2026-01-22T22:15:24.000Z
diff --git a/src/DataTypes/Serializations/SerializationObjectHelpers.cpp b/src/DataTypes/Serializations/SerializationObjectHelpers.cpp
@@ -227,6 +227,9 @@ void deserializeIndexesAndCollectPathsImpl(ColumnString & paths_column, ReadBuff
         T index;
         readBinaryLittleEndian(index, istr);
 
+        if (index >= paths.size())
+            throw Exception(ErrorCodes::LOGICAL_ERROR, "Object path index is out of range: {} >= {}", static_cast<UInt64>(index), paths.size());
+
         const String & path = paths[index];
         offset += path.size();
         offsets.push_back(offset);
@@ -283,7 +286,6 @@ void deserializeIndexesAndCollectPaths(IColumn & paths_column, ReadBuffer & istr
         default:
             throw Exception(ErrorCodes::LOGICAL_ERROR, "Unexpected column type of paths indexes: {}", indexes_type->getName());
     }
-
 }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,9 @@ void deserializeIndexesAndCollectPathsImpl(ColumnString & paths_column, ReadBuff`
`227`	`227`	`T index;`
`228`	`228`	`readBinaryLittleEndian(index, istr);`
`229`	`229`
	`230`	`+ if (index >= paths.size())`
	`231`	`+ throw Exception(ErrorCodes::LOGICAL_ERROR, "Object path index is out of range: {} >= {}", static_cast<UInt64>(index), paths.size());`
	`232`	`+`
`230`	`233`	`const String & path = paths[index];`
`231`	`234`	`offset += path.size();`
`232`	`235`	`offsets.push_back(offset);`
`@@ -283,7 +286,6 @@ void deserializeIndexesAndCollectPaths(IColumn & paths_column, ReadBuffer & istr`
`283`	`286`	`default:`
`284`	`287`	`throw Exception(ErrorCodes::LOGICAL_ERROR, "Unexpected column type of paths indexes: {}", indexes_type->getName());`
`285`	`288`	`}`
`286`		`-`
`287`	`289`	`}`
`288`	`290`
`289`	`291`	`}`