Handle constants carefully

novikd · novikd · commit 5fdaef851c87 · 2023-05-12T14:14:40.000Z
diff --git a/src/Analyzer/FunctionNode.cpp b/src/Analyzer/FunctionNode.cpp
@@ -210,7 +210,8 @@ ASTPtr FunctionNode::toASTImpl(const ConvertToASTOptions & options) const
     }
 
     auto new_options = options;
-    if (function_name == "_CAST")
+    /// To avoid surrounding constants with several internal casts.
+    if (function_name == "_CAST" && (*getArguments().begin())->getNodeType() == QueryTreeNodeType::CONSTANT)
         new_options.add_cast_for_constants = false;
 
     const auto & parameters = getParameters();

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,8 @@ ASTPtr FunctionNode::toASTImpl(const ConvertToASTOptions & options) const`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`auto new_options = options;`
`213`		`- if (function_name == "_CAST")`
	`213`	`+ /// To avoid surrounding constants with several internal casts.`
	`214`	`+ if (function_name == "_CAST" && (*getArguments().begin())->getNodeType() == QueryTreeNodeType::CONSTANT)`
`214`	`215`	`new_options.add_cast_for_constants = false;`
`215`	`216`
`216`	`217`	`const auto & parameters = getParameters();`