async_insert_race_long flakiness fixes

jkartseva · jkartseva · commit 572831f865d6 · 2024-08-02T01:02:07.000Z
1. Make the test truly asynchronous.
The setting `--async_insert_max_data_size 1` leads to data
being flushed synchronously for all inserts in this test.
This triggers part creation and extra resource consumption.

2. Do not run the `--wait_for_async_insert` query as a background process
with a fixed (50ms) sleep time.
If the actual execution time is longer than the anticipated delay
time, it may lead to excessive process creation.
diff --git a/tests/queries/0_stateless/02481_async_insert_race_long.sh b/tests/queries/0_stateless/02481_async_insert_race_long.sh
@@ -7,7 +7,7 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 # shellcheck source=../shell_config.sh
 . "$CURDIR"/../shell_config.sh
 
-export MY_CLICKHOUSE_CLIENT="$CLICKHOUSE_CLIENT --async_insert_busy_timeout_ms 10 --async_insert_max_data_size 1 --async_insert 1"
+export MY_CLICKHOUSE_CLIENT="$CLICKHOUSE_CLIENT --async_insert_busy_timeout_min_ms 50 --async_insert_busy_timeout_max_ms 50 --async_insert 1"
 
 function insert1()
 {
@@ -29,11 +29,8 @@ function insert3()
 {
     local TIMELIMIT=$((SECONDS+$1))
     while [ $SECONDS -lt "$TIMELIMIT" ]; do
-        ${MY_CLICKHOUSE_CLIENT} --insert_keeper_fault_injection_probability=0 --wait_for_async_insert 1 -q "INSERT INTO async_inserts_race VALUES (7, 'g') (8, 'h')" &
-        sleep 0.05
+        ${MY_CLICKHOUSE_CLIENT} --insert_keeper_fault_injection_probability=0 --wait_for_async_insert 1 -q "INSERT INTO async_inserts_race VALUES (7, 'g') (8, 'h')"
     done
-
-    wait
 }
 
 function select1()

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)`
`7`	`7`	`# shellcheck source=../shell_config.sh`
`8`	`8`	`. "$CURDIR"/../shell_config.sh`
`9`	`9`
`10`		`-export MY_CLICKHOUSE_CLIENT="$CLICKHOUSE_CLIENT --async_insert_busy_timeout_ms 10 --async_insert_max_data_size 1 --async_insert 1"`
	`10`	`+export MY_CLICKHOUSE_CLIENT="$CLICKHOUSE_CLIENT --async_insert_busy_timeout_min_ms 50 --async_insert_busy_timeout_max_ms 50 --async_insert 1"`
`11`	`11`
`12`	`12`	`function insert1()`
`13`	`13`	`{`
`@@ -29,11 +29,8 @@ function insert3()`
`29`	`29`	`{`
`30`	`30`	`local TIMELIMIT=$((SECONDS+$1))`
`31`	`31`	`while [ $SECONDS -lt "$TIMELIMIT" ]; do`
`32`		`- ${MY_CLICKHOUSE_CLIENT} --insert_keeper_fault_injection_probability=0 --wait_for_async_insert 1 -q "INSERT INTO async_inserts_race VALUES (7, 'g') (8, 'h')" &`
`33`		`- sleep 0.05`
	`32`	`+ ${MY_CLICKHOUSE_CLIENT} --insert_keeper_fault_injection_probability=0 --wait_for_async_insert 1 -q "INSERT INTO async_inserts_race VALUES (7, 'g') (8, 'h')"`
`34`	`33`	`done`
`35`		`-`
`36`		`- wait`
`37`	`34`	`}`
`38`	`35`
`39`	`36`	`function select1()`