Replace set<> with vector<?

shankar-iyer · shankar-iyer · commit 50f7207315c7 · 2025-05-28T13:49:27.000Z
diff --git a/src/Processors/QueryPlan/PartsSplitter.cpp b/src/Processors/QueryPlan/PartsSplitter.cpp
@@ -949,7 +949,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran
     }
 
     PartsRangesIterator selected_upper_bound;
-    std::vector<std::set<size_t>> part_selected_ranges(ranges_in_data_parts.size(), std::set<size_t>());
+    std::vector<std::vector<size_t>> part_selected_ranges(ranges_in_data_parts.size(), std::vector<size_t>());
     for (size_t part_index = 0; part_index < ranges_in_data_parts.size(); ++part_index)
     {
         const auto & index_granularity = ranges_in_data_parts[part_index].data_part->index_granularity;
@@ -970,7 +970,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran
                 selected_upper_bound = {range_end_value, false, range, part_index, PartsRangesIterator::EventType::RangeStart, true};
 
             for (auto i = range.begin; i < range.end; ++i)
-               part_selected_ranges[part_index].insert(i);
+               part_selected_ranges[part_index].push_back(i);
         }
     }
 
@@ -1004,7 +1004,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran
 
         for (auto range_begin = candidates_start.value(); range_begin <= candidates_end.value(); range_begin++)
         {
-            if (part_selected_ranges[part_index].find(range_begin) != part_selected_ranges[part_index].end())
+            if (std::binary_search(part_selected_ranges[part_index].begin(), part_selected_ranges[part_index].end(), range_begin))
                 continue;
             MarkRange rejected_range(range_begin, range_begin + 1);
             rejected_ranges.push_back(

Original file line number	Diff line number	Diff line change
`@@ -949,7 +949,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran`
`949`	`949`	`}`
`950`	`950`
`951`	`951`	`PartsRangesIterator selected_upper_bound;`
`952`		`- std::vector<std::set<size_t>> part_selected_ranges(ranges_in_data_parts.size(), std::set<size_t>());`
	`952`	`+ std::vector<std::vector<size_t>> part_selected_ranges(ranges_in_data_parts.size(), std::vector<size_t>());`
`953`	`953`	`for (size_t part_index = 0; part_index < ranges_in_data_parts.size(); ++part_index)`
`954`	`954`	`{`
`955`	`955`	`const auto & index_granularity = ranges_in_data_parts[part_index].data_part->index_granularity;`
`@@ -970,7 +970,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran`
`970`	`970`	`selected_upper_bound = {range_end_value, false, range, part_index, PartsRangesIterator::EventType::RangeStart, true};`
`971`	`971`
`972`	`972`	`for (auto i = range.begin; i < range.end; ++i)`
`973`		`- part_selected_ranges[part_index].insert(i);`
	`973`	`+ part_selected_ranges[part_index].push_back(i);`
`974`	`974`	`}`
`975`	`975`	`}`
`976`	`976`
`@@ -1004,7 +1004,7 @@ RangesInDataParts findPKRangesForFinalAfterSkipIndexImpl(RangesInDataParts & ran`
`1004`	`1004`
`1005`	`1005`	`for (auto range_begin = candidates_start.value(); range_begin <= candidates_end.value(); range_begin++)`
`1006`	`1006`	`{`
`1007`		`- if (part_selected_ranges[part_index].find(range_begin) != part_selected_ranges[part_index].end())`
	`1007`	`+ if (std::binary_search(part_selected_ranges[part_index].begin(), part_selected_ranges[part_index].end(), range_begin))`
`1008`	`1008`	`continue;`
`1009`	`1009`	`MarkRange rejected_range(range_begin, range_begin + 1);`
`1010`	`1010`	`rejected_ranges.push_back(`