Merge pull request #35755 from Avogar/fix-custom-to-string

Avogar · web-flow · commit 4ec3c35e14b5 · 2022-03-31T00:06:48.000+02:00
Fix bug in conversion from custom types to string
diff --git a/src/Functions/FunctionsConversion.h b/src/Functions/FunctionsConversion.h
@@ -887,7 +887,7 @@ struct ConvertImplGenericToString
         const IColumn & col_from = *col_with_type_and_name.column;
 
         size_t size = col_from.size();
-        auto col_to = result_type->createColumn();
+        auto col_to = removeNullable(result_type)->createColumn();
 
         {
             ColumnStringHelpers::WriteHelper write_helper(
diff --git a/tests/queries/0_stateless/02248_nullable_custom_types_to_string.reference b/tests/queries/0_stateless/02248_nullable_custom_types_to_string.reference
@@ -0,0 +1,6 @@
+true
+\N
+0.0.0.0
+\N
+::ffff:127.0.0.1
+\N
diff --git a/tests/queries/0_stateless/02248_nullable_custom_types_to_string.sql b/tests/queries/0_stateless/02248_nullable_custom_types_to_string.sql
@@ -0,0 +1,6 @@
+select toString(toNullable(true));
+select toString(CAST(NULL, 'Nullable(Bool)'));
+select toString(toNullable(toIPv4('0.0.0.0')));
+select toString(CAST(NULL, 'Nullable(IPv4)'));
+select toString(toNullable(toIPv6('::ffff:127.0.0.1')));
+select toString(CAST(NULL, 'Nullable(IPv6)'));

Original file line number	Diff line number	Diff line change
`@@ -887,7 +887,7 @@ struct ConvertImplGenericToString`
`887`	`887`	`const IColumn & col_from = *col_with_type_and_name.column;`
`888`	`888`
`889`	`889`	`size_t size = col_from.size();`
`890`		`- auto col_to = result_type->createColumn();`
	`890`	`+ auto col_to = removeNullable(result_type)->createColumn();`
`891`	`891`
`892`	`892`	`{`
`893`	`893`	`ColumnStringHelpers::WriteHelper write_helper(`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +true
 +\N
 +0.0.0.0
 +\N
 +::ffff:127.0.0.1
 +\N