Minmax indices by default

alexey-milovidov · alexey-milovidov · commit 3da8ca103b8e · 2025-02-27T11:47:09.000+01:00
diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp
@@ -663,6 +663,7 @@ const VersionToSettingsChangesMap & getMergeTreeSettingsChangesHistory()
         addSettingsChanges(merge_tree_settings_changes_history, "25.3",
         {
             {"shared_merge_tree_enable_keeper_parts_extra_data", false, false, "New setting"},
+            {"add_minmax_index_for_numeric_columns", false, true, "Should give benefits."},
         });
         addSettingsChanges(merge_tree_settings_changes_history, "25.2",
         {
diff --git a/src/Storages/MergeTree/MergeTreeSettings.cpp b/src/Storages/MergeTree/MergeTreeSettings.cpp
@@ -261,7 +261,7 @@ namespace ErrorCodes
     DECLARE(Bool, disable_fetch_partition_for_zero_copy_replication, true, "Disable FETCH PARTITION query for zero copy replication.", 0) \
     DECLARE(Bool, enable_block_number_column, false, "Enable persisting column _block_number for each row.", 0) ALIAS(allow_experimental_block_number_column) \
     DECLARE(Bool, enable_block_offset_column, false, "Enable persisting column _block_offset for each row.", 0) \
-    DECLARE(Bool, add_minmax_index_for_numeric_columns, false, "Automatically create min-max indices for columns of numeric type", 0) \
+    DECLARE(Bool, add_minmax_index_for_numeric_columns, true, "Automatically create min-max indices for columns of numeric type", 0) \
     DECLARE(Bool, add_minmax_index_for_string_columns, false, "Automatically create min-max indices for columns of string type", 0) \
     \
     /** Experimental/work in progress feature. Unsafe for production. */ \

Original file line number	Diff line number	Diff line change
`@@ -663,6 +663,7 @@ const VersionToSettingsChangesMap & getMergeTreeSettingsChangesHistory()`
`663`	`663`	`addSettingsChanges(merge_tree_settings_changes_history, "25.3",`
`664`	`664`	`{`
`665`	`665`	`{"shared_merge_tree_enable_keeper_parts_extra_data", false, false, "New setting"},`
	`666`	`+ {"add_minmax_index_for_numeric_columns", false, true, "Should give benefits."},`
`666`	`667`	`});`
`667`	`668`	`addSettingsChanges(merge_tree_settings_changes_history, "25.2",`
`668`	`669`	`{`
Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ namespace ErrorCodes`
`261`	`261`	`DECLARE(Bool, disable_fetch_partition_for_zero_copy_replication, true, "Disable FETCH PARTITION query for zero copy replication.", 0) \`
`262`	`262`	`DECLARE(Bool, enable_block_number_column, false, "Enable persisting column _block_number for each row.", 0) ALIAS(allow_experimental_block_number_column) \`
`263`	`263`	`DECLARE(Bool, enable_block_offset_column, false, "Enable persisting column _block_offset for each row.", 0) \`
`264`		`- DECLARE(Bool, add_minmax_index_for_numeric_columns, false, "Automatically create min-max indices for columns of numeric type", 0) \`
	`264`	`+ DECLARE(Bool, add_minmax_index_for_numeric_columns, true, "Automatically create min-max indices for columns of numeric type", 0) \`
`265`	`265`	`DECLARE(Bool, add_minmax_index_for_string_columns, false, "Automatically create min-max indices for columns of string type", 0) \`
`266`	`266`	`\`
`267`	`267`	`/** Experimental/work in progress feature. Unsafe for production. */ \`