tests: fix test_quorum_inserts flakiness

azat · azat · commit 3728eb574544 · 2025-03-05T16:35:26.000+01:00
Fix the unpredictible nature of
test_insert_quorum_with_keeper_loss_connection, that leads to failures
of other tests due to some failpoints leaved as active.
diff --git a/tests/integration/test_quorum_inserts/test.py b/tests/integration/test_quorum_inserts/test.py
@@ -379,11 +379,25 @@ def test_insert_quorum_with_keeper_loss_connection(started_cluster):
             )
         )
 
+        zk = cluster.get_kazoo_client("zoo1")
+
+        # Ensure that part had been committed
+        retries = 0
+        while True:
+            if zk.exists(
+                f"/clickhouse/tables/{table_name}/replicas/zero/parts/all_0_0_0"
+            ):
+                break
+            print("replica still did not create all_0_0_0")
+            time.sleep(1)
+            retries += 1
+            if retries == 120:
+                raise Exception("Can not wait for all_0_0_0 part")
+
         with PartitionManager() as pm:
             pm.drop_instance_zk_connections(zero)
 
             retries = 0
-            zk = cluster.get_kazoo_client("zoo1")
             while True:
                 if (
                     zk.exists(
