Follow-ups

alexey-milovidov · alexey-milovidov · commit 2ccf78b08157 · 2025-03-21T11:34:56.000+01:00
diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp
@@ -86,6 +86,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
             {"iceberg_snapshot_id", 0, 0, "New setting."},
             {"parallel_replicas_for_cluster_engines", false, true, "New setting."},
             /// Release closed. Please use 25.4
+            {"use_local_cache_for_remote_storage", true, false, "Obsolete setting."},
         });
         addSettingsChanges(settings_changes_history, "25.2",
         {
diff --git a/src/Storages/Hive/StorageHive.cpp b/src/Storages/Hive/StorageHive.cpp
@@ -233,7 +233,6 @@ class StorageHiveSource : public ISource, WithContext
                     return generateChunkFromMetadata();
                 }
 
-                String uri_with_path = hdfs_namenode_url + current_path;
                 auto compression = chooseCompressionMethod(current_path, compression_method);
                 std::unique_ptr<ReadBuffer> raw_read_buf;
                 try

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()`
`86`	`86`	`{"iceberg_snapshot_id", 0, 0, "New setting."},`
`87`	`87`	`{"parallel_replicas_for_cluster_engines", false, true, "New setting."},`
`88`	`88`	`/// Release closed. Please use 25.4`
	`89`	`+ {"use_local_cache_for_remote_storage", true, false, "Obsolete setting."},`
`89`	`90`	`});`
`90`	`91`	`addSettingsChanges(settings_changes_history, "25.2",`
`91`	`92`	`{`
Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,6 @@ class StorageHiveSource : public ISource, WithContext`
`233`	`233`	`return generateChunkFromMetadata();`
`234`	`234`	`}`
`235`	`235`
`236`		`- String uri_with_path = hdfs_namenode_url + current_path;`
`237`	`236`	`auto compression = chooseCompressionMethod(current_path, compression_method);`
`238`	`237`	`std::unique_ptr<ReadBuffer> raw_read_buf;`
`239`	`238`	`try`