Tidy fixes

Algunenano · Algunenano · commit 16c54a80d3f6 · 2025-07-03T21:52:39.000+02:00
diff --git a/src/Loggers/OwnSplitChannel.cpp b/src/Loggers/OwnSplitChannel.cpp
@@ -274,7 +274,7 @@ void OwnAsyncSplitChannel::close()
 class AsyncLogMessage
 {
 public:
-    AsyncLogMessage(const Message & msg_)
+    explicit AsyncLogMessage(const Message & msg_)
         : msg(msg_)
         , msg_ext(ExtendedLogMessage::getFrom(msg))
         , msg_thread_name(getThreadName())
@@ -297,7 +297,7 @@ class AsyncLogMessage
 };
 
 
-void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr pNotification)
+void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr message)
 {
     std::unique_lock lock(mutex);
     size_t current_size = message_queue.size();
@@ -314,7 +314,7 @@ void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr pNotification)
         dropped_messages = 0;
     }
 
-    message_queue.push_back(pNotification);
+    message_queue.push_back(message);
     condition.notify_one();
 }
 
@@ -422,7 +422,7 @@ void OwnAsyncSplitChannel::runChannel(size_t i)
     {
         if (!async_message)
             return;
-        auto * own_notification = dynamic_cast<const AsyncLogMessage *>(async_message.get());
+        const auto * own_notification = dynamic_cast<const AsyncLogMessage *>(async_message.get());
         {
             if (own_notification)
             {

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ void OwnAsyncSplitChannel::close()`
`274`	`274`	`class AsyncLogMessage`
`275`	`275`	`{`
`276`	`276`	`public:`
`277`		`- AsyncLogMessage(const Message & msg_)`
	`277`	`+ explicit AsyncLogMessage(const Message & msg_)`
`278`	`278`	`: msg(msg_)`
`279`	`279`	`, msg_ext(ExtendedLogMessage::getFrom(msg))`
`280`	`280`	`, msg_thread_name(getThreadName())`
`@@ -297,7 +297,7 @@ class AsyncLogMessage`
`297`	`297`	`};`
`298`	`298`
`299`	`299`
`300`		`-void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr pNotification)`
	`300`	`+void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr message)`
`301`	`301`	`{`
`302`	`302`	`std::unique_lock lock(mutex);`
`303`	`303`	`size_t current_size = message_queue.size();`
`@@ -314,7 +314,7 @@ void AsyncLogMessageQueue::enqueueMessage(AsyncLogMessagePtr pNotification)`
`314`	`314`	`dropped_messages = 0;`
`315`	`315`	`}`
`316`	`316`
`317`		`- message_queue.push_back(pNotification);`
	`317`	`+ message_queue.push_back(message);`
`318`	`318`	`condition.notify_one();`
`319`	`319`	`}`
`320`	`320`
`@@ -422,7 +422,7 @@ void OwnAsyncSplitChannel::runChannel(size_t i)`
`422`	`422`	`{`
`423`	`423`	`if (!async_message)`
`424`	`424`	`return;`
`425`		`- auto * own_notification = dynamic_cast<const AsyncLogMessage *>(async_message.get());`
	`425`	`+ const auto * own_notification = dynamic_cast<const AsyncLogMessage *>(async_message.get());`
`426`	`426`	`{`
`427`	`427`	`if (own_notification)`
`428`	`428`	`{`