Backport #89139 to 25.9: Fix potential heap-use-after-free in projections analysis after #72102

robot-clickhouse · robot-clickhouse · commit 15a5f058ae9b · 2025-11-04T18:15:30.000Z
diff --git a/src/Storages/MergeTree/MergeTreeData.cpp b/src/Storages/MergeTree/MergeTreeData.cpp
@@ -8187,7 +8187,8 @@ Block MergeTreeData::getMinMaxCountProjectionBlock(
         {
             for (const auto & part : real_parts)
             {
-                const auto & primary_key_column = *part->getIndex()->at(0);
+                auto index = part->getIndex();
+                const auto & primary_key_column = *index->at(0);
                 auto & min_column = assert_cast<ColumnAggregateFunction &>(*partition_minmax_count_columns[pos]);
                 insert(min_column, primary_key_column[0]);
             }
@@ -8198,7 +8199,8 @@ Block MergeTreeData::getMinMaxCountProjectionBlock(
         {
             for (const auto & part : real_parts)
             {
-                const auto & primary_key_column = *part->getIndex()->at(0);
+                auto index = part->getIndex();
+                const auto & primary_key_column = *index->at(0);
                 auto & max_column = assert_cast<ColumnAggregateFunction &>(*partition_minmax_count_columns[pos]);
                 insert(max_column, primary_key_column[primary_key_column.size() - 1]);
             }

Original file line number	Diff line number	Diff line change
`@@ -8187,7 +8187,8 @@ Block MergeTreeData::getMinMaxCountProjectionBlock(`
`8187`	`8187`	`{`
`8188`	`8188`	`for (const auto & part : real_parts)`
`8189`	`8189`	`{`
`8190`		`- const auto & primary_key_column = *part->getIndex()->at(0);`
	`8190`	`+ auto index = part->getIndex();`
	`8191`	`+ const auto & primary_key_column = *index->at(0);`
`8191`	`8192`	`auto & min_column = assert_cast<ColumnAggregateFunction &>(*partition_minmax_count_columns[pos]);`
`8192`	`8193`	`insert(min_column, primary_key_column[0]);`
`8193`	`8194`	`}`
`@@ -8198,7 +8199,8 @@ Block MergeTreeData::getMinMaxCountProjectionBlock(`
`8198`	`8199`	`{`
`8199`	`8200`	`for (const auto & part : real_parts)`
`8200`	`8201`	`{`
`8201`		`- const auto & primary_key_column = *part->getIndex()->at(0);`
	`8202`	`+ auto index = part->getIndex();`
	`8203`	`+ const auto & primary_key_column = *index->at(0);`
`8202`	`8204`	`auto & max_column = assert_cast<ColumnAggregateFunction &>(*partition_minmax_count_columns[pos]);`
`8203`	`8205`	`insert(max_column, primary_key_column[primary_key_column.size() - 1]);`
`8204`	`8206`	`}`