add assert in d-tor ReplicatedMergeTreeSinkImpl

CheSema · CheSema · commit 0a9ac03671f9 · 2024-11-30T12:37:18.000+01:00
diff --git a/src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp b/src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp
@@ -179,6 +179,8 @@ ReplicatedMergeTreeSinkImpl<async_insert>::~ReplicatedMergeTreeSinkImpl()
     if (!delayed_chunk)
         return;
 
+    chassert(isCancelled() || std::uncaught_exceptions());
+
     for (auto & partition : delayed_chunk->partitions)
     {
         partition.temp_part.cancel();

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,8 @@ ReplicatedMergeTreeSinkImpl<async_insert>::~ReplicatedMergeTreeSinkImpl()`
`179`	`179`	`if (!delayed_chunk)`
`180`	`180`	`return;`
`181`	`181`
	`182`	`+ chassert(isCancelled() \|\| std::uncaught_exceptions());`
	`183`	`+`
`182`	`184`	`for (auto & partition : delayed_chunk->partitions)`
`183`	`185`	`{`
`184`	`186`	`partition.temp_part.cancel();`