Fix compilation

vitlibar · vitlibar · commit 04fd5ebc561a · 2026-02-11T16:54:06.000+01:00
diff --git a/src/Storages/TimeSeries/PrometheusQueryToSQL/NodeEvaluationRangeGetter.cpp b/src/Storages/TimeSeries/PrometheusQueryToSQL/NodeEvaluationRangeGetter.cpp
@@ -151,31 +151,29 @@ void NodeEvaluationRangeGetter::visitChildren(const Node * node, const NodeEvalu
 void NodeEvaluationRangeGetter::setWindows()
 {
     /// Assign windows for instant selectors.
-    for (auto it = map.begin(); it != map.end(); ++it)
+    for (auto & [node, node_range] : map)
     {
-        const auto * node = it->first;
         if (node->node_type == NodeType::InstantSelector)
         {
             /// The following setting may be overwritten later if this instant selector node is a part of a range selector
             /// (see below).
-            it->second.window = instant_selector_window;
+            node_range.window = instant_selector_window;
         }
         else
         {
             /// If the window isn't used we set it to zero.
-            it->second.window = 0;
+            node_range.window = 0;
         }
     }
 
     /// Assign windows for range selectors and subqueries, and propagate these ranges to other nodes.
-    for (auto it = map.begin(); it != map.end(); ++it)
+    for (auto & [node, node_range] : map)
     {
-        const auto * node = it->first;
         if (node->node_type == NodeType::RangeSelector)
         {
             const auto * range_selector_node = static_cast<const PQT::RangeSelector *>(node);
             auto range = range_selector_node->range;
-            it->second.window = range;
+            node_range.window = range;
             const auto * instant_selector_node = range_selector_node->getInstantSelector();
             map.at(instant_selector_node).window = range;
             /// We propagate the range of a range selector up to its parents until we meet a range-vector function
@@ -188,7 +186,7 @@ void NodeEvaluationRangeGetter::setWindows()
             /// (e.g. avg_over_time) if any, so such function could user a proper window.
             const auto * subquery_node = static_cast<const PQT::Subquery *>(node);
             auto range = subquery_node->range;
-            it->second.window = range;
+            node_range.window = range;
             propagateRangeToParents(node, range);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -151,31 +151,29 @@ void NodeEvaluationRangeGetter::visitChildren(const Node * node, const NodeEvalu`
`151`	`151`	`void NodeEvaluationRangeGetter::setWindows()`
`152`	`152`	`{`
`153`	`153`	`/// Assign windows for instant selectors.`
`154`		`- for (auto it = map.begin(); it != map.end(); ++it)`
	`154`	`+ for (auto & [node, node_range] : map)`
`155`	`155`	`{`
`156`		`- const auto * node = it->first;`
`157`	`156`	`if (node->node_type == NodeType::InstantSelector)`
`158`	`157`	`{`
`159`	`158`	`/// The following setting may be overwritten later if this instant selector node is a part of a range selector`
`160`	`159`	`/// (see below).`
`161`		`- it->second.window = instant_selector_window;`
	`160`	`+ node_range.window = instant_selector_window;`
`162`	`161`	`}`
`163`	`162`	`else`
`164`	`163`	`{`
`165`	`164`	`/// If the window isn't used we set it to zero.`
`166`		`- it->second.window = 0;`
	`165`	`+ node_range.window = 0;`
`167`	`166`	`}`
`168`	`167`	`}`
`169`	`168`
`170`	`169`	`/// Assign windows for range selectors and subqueries, and propagate these ranges to other nodes.`
`171`		`- for (auto it = map.begin(); it != map.end(); ++it)`
	`170`	`+ for (auto & [node, node_range] : map)`
`172`	`171`	`{`
`173`		`- const auto * node = it->first;`
`174`	`172`	`if (node->node_type == NodeType::RangeSelector)`
`175`	`173`	`{`
`176`	`174`	`const auto * range_selector_node = static_cast<const PQT::RangeSelector *>(node);`
`177`	`175`	`auto range = range_selector_node->range;`
`178`		`- it->second.window = range;`
	`176`	`+ node_range.window = range;`
`179`	`177`	`const auto * instant_selector_node = range_selector_node->getInstantSelector();`
`180`	`178`	`map.at(instant_selector_node).window = range;`
`181`	`179`	`/// We propagate the range of a range selector up to its parents until we meet a range-vector function`
`@@ -188,7 +186,7 @@ void NodeEvaluationRangeGetter::setWindows()`
`188`	`186`	`/// (e.g. avg_over_time) if any, so such function could user a proper window.`
`189`	`187`	`const auto * subquery_node = static_cast<const PQT::Subquery *>(node);`
`190`	`188`	`auto range = subquery_node->range;`
`191`		`- it->second.window = range;`
	`189`	`+ node_range.window = range;`
`192`	`190`	`propagateRangeToParents(node, range);`
`193`	`191`	`}`
`194`	`192`	`}`