Small improvements to the benchmarking pipeline#5421
Merged
Conversation
Collaborator
giordano
commented
Mar 21, 2026
giordano
commented
- always run the benchmarking script, not just when certain files are modified: while that'd be the right thing to do when the entire process is handled through GitHub Actions, the benchmark pipeline in Buildkite is always run, so we'd be better following what we do in Buildkite
- ClimaSeaIce is completely unused, ref: Benchmarking script depends on downstream packages #5418 (comment)
giordano
added
the
benchmark performance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5421 +/- ##
=======================================
Coverage 68.84% 68.84%
=======================================
Files 398 398
Lines 21963 21963
=======================================
Hits 15121 15121
Misses 6842 6842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navidcy
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.