Temporarily drop Benchmark section from Docs + delete legacy_benchmarks#5412
Merged
Temporarily drop Benchmark section from Docs + delete legacy_benchmarks#5412
legacy_benchmarks#5412Conversation
Member
|
Right, we should not merge this but instead update the docs to point to the benchmarks we will continue to add to and maintain. |
Collaborator
Author
|
Do you want me to just change the link, or does the surrounding text also need updating (in which case I think best you or someone knowledgeable about these benchmarks writes it)? |
Member
navidcy
added
documentation 📜
Member
|
I don't think it's just a link change as the whole directory structure changed so probably some rephrasing is needed? |
Member
|
To make a quick PR we can just comment out the docs section, then restore it in a new PR. |
navidcy
force-pushed
the
bp/legacy-benchmark-docs-link
branch
from
77523fe to
3d0cd68
Compare
Member
|
Done. Should we also delete the |
navidcy
changed the title
navidcy
approved these changes
Mar 19, 2026
navidcy
changed the title
legacy_benchmarks
Member
Question was answered here: #5317 (comment) |
Member
|
How long the benchmark CI should take? It’s been 3hrs. Is that expected? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
+ Coverage 68.73% 68.82% +0.09%
==========================================
Files 398 398
Lines 21920 21968 +48
==========================================
+ Hits 15066 15119 +53
+ Misses 6854 6849 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glwagner
added a commit
that referenced
this pull request
Mar 21, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
briochemc
added a commit
to briochemc/Oceananigans.jl
that referenced
this pull request
Mar 23, 2026
…ine-ACCESS-OM2 * bp-claude/distributed-FPivot-TripolarGrid: Replace reverse() with reversed-range views in fold halo fills Reinstate Docs/Benchmarks (CliMA#5419) Update fill_halo_regions.jl (CliMA#5415) Temporarily drop Benchmark section from Docs + delete `legacy_benchmarks` (CliMA#5412) Add restart verification script (CliMA#5379) Rework support for reduction operations on Metal GPU to avoid materialization of the interior (CliMA#5329) Fix typo with density perturbation in docs (CliMA#5398) Implement ReactantCore.materialize_traced_array for Field (CliMA#5409) Remove Oceananigans dependency from Project.toml (CliMA#5414) (0.106) Log checkpoint file and mtime when restoring simulations (CliMA#5355)
glwagner
added a commit
that referenced
this pull request
Mar 23, 2026
* Extend TabulatedFunction to support 4D quadrilinear interpolation Add support for 4-dimensional lookup tables with quadrilinear interpolation, following the same patterns as the existing 1D/2D/3D implementations. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * Extend TabulatedFunction to support 5D quintilinear interpolation Same mechanical pattern as 4D: adds 5D kernel, builder, evaluation method, 32-term _interpolate, TabulatedFunction5D alias, and comprehensive tests. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * Apply suggestions from code review Co-authored-by: Navid C. Constantinou <[email protected]> * Ignore legacy_benchmark linkcheck (directory removed in #5412) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * Apply suggestion from @glwagner --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> Co-authored-by: Navid C. Constantinou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5317 (comment)
EDIT: This is my quick band-aid fix, pointing to the "archived" directory, so that the docs build during CI. But maybe you guys want to revise that section of the docs and point to the new "benchmarking" directory?