Implement ReactantCore.materialize_traced_array for Field#5409
Merged
glwagner merged 1 commit intoCliMA:mainfrom Mar 19, 2026
Merged
Implement ReactantCore.materialize_traced_array for Field#5409glwagner merged 1 commit intoCliMA:mainfrom
glwagner merged 1 commit intoCliMA:mainfrom
Conversation
glwagner
approved these changes
Mar 18, 2026
Member
glwagner
left a comment
glwagner
left a comment
There was a problem hiding this comment.
what's the purpose of materialize_traced_array?
Collaborator
Author
|
|
Member
|
got it! so the important part about |
Collaborator
Author
|
Yes since Field is a SubArray in a trench coat we can just call the corresponding method in Reactant: https://github.com/EnzymeAD/Reactant.jl/blob/f77e876bbea9e974173eb922e3185f8a85a021ab/src/TracedUtils.jl#L63-L65 |
briochemc
added a commit
to briochemc/Oceananigans.jl
that referenced
this pull request
Mar 23, 2026
…ine-ACCESS-OM2 * bp-claude/distributed-FPivot-TripolarGrid: Replace reverse() with reversed-range views in fold halo fills Reinstate Docs/Benchmarks (CliMA#5419) Update fill_halo_regions.jl (CliMA#5415) Temporarily drop Benchmark section from Docs + delete `legacy_benchmarks` (CliMA#5412) Add restart verification script (CliMA#5379) Rework support for reduction operations on Metal GPU to avoid materialization of the interior (CliMA#5329) Fix typo with density perturbation in docs (CliMA#5398) Implement ReactantCore.materialize_traced_array for Field (CliMA#5409) Remove Oceananigans dependency from Project.toml (CliMA#5414) (0.106) Log checkpoint file and mtime when restoring simulations (CliMA#5355)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the StackOverflow error from NumericalEarth/Breeze.jl#565 (comment).