Improve serial tripolar grid fold tests#5405
Merged
Conversation
- Add FF (Face, Face) field to tests all 4 stagger locations - Add `rot180` symmetry/antisymmetry - Fix ASCII diagram pivot point placement (F was on wrong row) - Group tests into @testset blocks for better diagnostics
briochemc
requested review from
glwagner,
navidcy,
simone-silvestri and
taimoorsohail
simone-silvestri
approved these changes
Mar 17, 2026
Collaborator
Author
|
I just added some (serial) tests and a validation/plotting script, so not sure why the distributed test is failing. Any objections to merging? |
Collaborator
|
There are library problems on the caltech cluster where we run the tests that they are trying to solve. It is an unrelated issue, let's merge! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5405 +/- ##
==========================================
+ Coverage 68.84% 73.49% +4.64%
==========================================
Files 398 398
Lines 21963 22673 +710
==========================================
+ Hits 15121 16664 +1543
+ Misses 6842 6009 -833
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the serial tripolar test a bit cleaner and more comprehensive by (i) making sure that all halo points and staggered locations are tested, and (ii) by adding a slightly different way of testing the rotational symmetry (a double check).
This PR does the following:
rot180function@testsetblocksI wanted to do this to make sure that the serial fold is 100% correct, after a discussion with @simone-silvestri. We also discussed changing the
RightFaceFoldedimplementation to have no extra row butNy+1-sizedv, as this will likely be simpler for users and help with implementing the distributed case. If this happens these tests will need to be adjusted, but I think it should be fairly easy to make these adjustments.I have also added a validation script that visualizes the origin of all the north halo fills, with arcs going from interior source to halo destination, for all topologies and all field locations. The PNGs it produces:
These might be helpful for the distributed case too.