Fix HydroStaticFreeSurfaceModel init for open boundary conditions with SplitExplicitFreeSurface#5378
Merged
simone-silvestri merged 7 commits intoCliMA:ss/open-boundary-conditionsfrom Mar 6, 2026
Conversation
...Models/HydrostaticFreeSurfaceModels/SplitExplicitFreeSurfaces/split_explicit_free_surface.jl
Outdated
Show resolved
Hide resolved
simone-silvestri
approved these changes
Mar 6, 2026
Collaborator
simone-silvestri
left a comment
simone-silvestri
left a comment
There was a problem hiding this comment.
Thanks for the bugfixes! I have added some comments.
Co-authored-by: Simone Silvestri <[email protected]>
Co-authored-by: Simone Silvestri <[email protected]>
simone-silvestri
merged commit 3d690c8
into
CliMA:ss/open-boundary-conditions
21 of 54 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
internal_tide_open_boundariesexample fails with:I think this is for two reasons:
UandVare not listed in theassumed_field_locationmapping for boundary condition locations, so they fall through to theCenter(), Center(), Center()default which is incorrect for a 2D fieldMissing dispatch for validating boundary conditions on aNote: this was extra, I've removed it after review.nothingz-location, so this also falls through to a catch-all errorThis pull request adds a mapping for
UandV. I've also added missing references in a couple of places. The example runs with these changes, but I have not checked it for correctness.I'm very new to Oceananigans, so please double check and feel free to make any changes to this branch.