Skip to content

Add manual restart verification to examples#5372

Closed
ewquon wants to merge 1 commit intoCliMA:mainfrom
ewquon:eq/manual_restart_verification
Closed

Add manual restart verification to examples#5372
ewquon wants to merge 1 commit intoCliMA:mainfrom
ewquon:eq/manual_restart_verification

Conversation

@ewquon
Copy link
Copy Markdown
Collaborator

@ewquon ewquon commented Mar 4, 2026

Documenting results here to inform NumericalEarth/Breeze.jl#529

The restart_verification.sh semi-automates the testing in an old-school way, running 0->200 iterations from scratch and comparing with 100->200 iterations restarted. Results are from my macbook with Julia v1.12.5 and the following environment:

  [033835bb] JLD2 v0.6.3
  [85f8d34a] NCDatasets v0.14.12
⌅ [9e8cae18] Oceananigans v0.105.1
  [d496a93d] SeawaterPolynomials v0.3.10
Example Problem Restart is Bitwise Identical Notes
baroclinic_adjustment.jl ✅
convecting_plankton.jl ✅
horizontal_convection.jl ✅
hydrostatic_lock_exchange.jl ✅
internal_tide.jl ✅
internal_wave.jl ✅
kelvin_helmholtz_instability.jl ? need to check simulation steps
langmuir_turbulence.jl ? need to check simulation steps
ocean_wind_mixing_and_convection.jl ☑️ abs diff ~O(1e-13)
one_dimensional_diffusion.jl ✅
shallow_water_Bickley_jet.jl ✅
spherical_baroclinic_instability.jl (lat-lon) ✅ ran on CPU
spherical_baroclinic_instability.jl (tripolar) ❌ ran on CPU
spherical_baroclinic_instability.jl (rotated lat-lon) ✅ ran on CPU
tilted_bottom_boundary_layer.jl ? need to check simulation steps
two_dimensional_turbulence.jl ✅

@ewquon ewquon marked this pull request as draft March 4, 2026 22:53
glwagner
glwagner reviewed Mar 4, 2026
View reviewed changes
examples/restart_verification.sh
Copy link
Copy Markdown
Member

@glwagner glwagner Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use a julia script here?

Copy link
Copy Markdown
Collaborator

@giordano giordano Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that a Julia script driving this would have the benefit of being cross-platform (Windows being the main offender), people would have to have Julia anyway if they want to use Oceananigans.

Copy link
Copy Markdown
Collaborator Author

@ewquon ewquon Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that started out quick and dirty for my work but it sounds like there's value in me cleaning it up, so I'll get on that.

@glwagner
Copy link
Copy Markdown
Member

glwagner commented Mar 4, 2026 •
edited
Loading

This seems interesting --- basically a tool that will take a script and test that the Simulation implemented in that script is bitwise restartable? Neat.

My main suggestion is to use a julia script rather than a bash script for the utility, which could have a number of benefits. @giordano might have some thoughts. It could also be fun to see an example of how to use it.

@ewquon
Copy link
Copy Markdown
Collaborator Author

ewquon commented Mar 5, 2026

Let me start fresh.

@ewquon ewquon closed this Mar 5, 2026
@ewquon ewquon mentioned this pull request Mar 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giordano giordano giordano left review comments

@glwagner glwagner glwagner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewquon @glwagner @giordano