Conversation
Should be easy to make the dynamics hydrostatic by using a large aspect ratio |
Right, I was kind of avoiding doing that because we also want to test the nonhydrostatic capabilities of flow_over_flat_hill_nonhydrostatic_Nz.16.jld2.mp4flow_over_flat_hill_hydrostatic_with_implicit_surface_Nz.16.jld2.mp4flow_over_steep_hill_nonhydrostatic_Nz.32.jld2.mp4I'm not super familiar with hydrostatic physics, so it'd be good to have a second set of eyes in these examples, but the animations look reasonable to me when taking into consideration the limitations of each model. |
|
@simone-silvestri do you mind taking a look at this validation? After we merge this I'd like your work in #5351 to it |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 74.01% 68.89% -5.12%
==========================================
Files 400 400
Lines 22875 22153 -722
==========================================
- Hits 16930 15263 -1667
- Misses 5945 6890 +945
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ali-ramadhan
left a comment
There was a problem hiding this comment.
Looks good to merge! I just left a couple of minor comments.
Sorry was on vacation for a while. Looks good! |
Co-authored-by: Simone Silvestri <[email protected]>
…anigans.jl into tc/add-open-hydro-validation
…anigans.jl into tc/add-open-hydro-validation
Adds a validation example that can use both a
NonhydrostaticModelandHydrostaticFreeSurfaceModelwith an implicit surface.The solution of the hydrostatic model here isn't very good since the physics are inherently non-hydrostatic, but the main purpose here is to test that the model works in the sense that it produces what we would expect it to produce.After this is merged I intend to add a SplitExplicit hydrostatic model to the same script in #5351.cc @simone-silvestri