Skip to content

Add flow over hill validation using open boundaries and a hydrostatic model with implicit surface#5359

Merged
tomchor merged 28 commits intomainfrom
tc/add-open-hydro-validation
Mar 25, 2026
Merged

Add flow over hill validation using open boundaries and a hydrostatic model with implicit surface#5359
tomchor merged 28 commits intomainfrom
tc/add-open-hydro-validation

Conversation

@tomchor
Copy link
Copy Markdown
Member

@tomchor tomchor commented Mar 3, 2026

Adds a validation example that can use both a NonhydrostaticModel and HydrostaticFreeSurfaceModel with an implicit surface. The solution of the hydrostatic model here isn't very good since the physics are inherently non-hydrostatic, but the main purpose here is to test that the model works in the sense that it produces what we would expect it to produce. After this is merged I intend to add a SplitExplicit hydrostatic model to the same script in #5351.

cc @simone-silvestri

@glwagner
Copy link
Copy Markdown
Member

glwagner commented Mar 3, 2026

Adds a validation example that can use both a NonhydrostaticModel and HydrostaticFreeSurfaceModel with an implicit surface. The solution of the hydrostatic model here isn't very good since the physics are inherently non-hydrostatic, but the main purpose here is to test that the model works in the sense that it produces what we would expect it to produce. After this is merged I intend to add a SplitExplicit hydrostatic model to the same script in #5351.

cc @simone-silvestri

Should be easy to make the dynamics hydrostatic by using a large aspect ratio

@tomchor tomchor changed the title Add flow over hill validation using open boundaries and a hydrostatic model with implciit surface Add flow over hill validation using open boundaries and a hydrostatic model with implicit surface Mar 10, 2026
@tomchor tomchor marked this pull request as ready for review March 12, 2026 10:15
@tomchor
Copy link
Copy Markdown
Member Author

tomchor commented Mar 12, 2026

Should be easy to make the dynamics hydrostatic by using a large aspect ratio

Right, I was kind of avoiding doing that because we also want to test the nonhydrostatic capabilities of PerturbationAdvection, but there's no reason we can't do both. So I made the validation script very flexible, and as it is it runs three cases: a very flat (i.e. hydrostatic physics) hill with the nonhydrostatic model + free surface, the same setup with a hydrostatic implicit free surface model, and a steep hill with a nonhydrostatic model with rigid lid. Hey there are respectively:

flow_over_flat_hill_nonhydrostatic_Nz.16.jld2.mp4
flow_over_flat_hill_hydrostatic_with_implicit_surface_Nz.16.jld2.mp4
flow_over_steep_hill_nonhydrostatic_Nz.32.jld2.mp4

I'm not super familiar with hydrostatic physics, so it'd be good to have a second set of eyes in these examples, but the animations look reasonable to me when taking into consideration the limitations of each model.

@tomchor
Copy link
Copy Markdown
Member Author

tomchor commented Mar 18, 2026

@simone-silvestri do you mind taking a look at this validation? After we merge this I'd like your work in #5351 to it

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.89%. Comparing base (85ba915) to head (6e29156).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (85ba915) and HEAD (6e29156). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (85ba915) HEAD (6e29156)
8 0
reactant_unit 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5359      +/-   ##
==========================================
- Coverage   74.01%   68.89%   -5.12%     
==========================================
  Files         400      400              
  Lines       22875    22153     -722     
==========================================
- Hits        16930    15263    -1667     
- Misses       5945     6890     +945     
Flag Coverage Δ
buildkite 68.89% <ø> (ø)
julia 68.89% <ø> (ø)
reactant_unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ali-ramadhan ali-ramadhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge! I just left a couple of minor comments.

@simone-silvestri
Copy link
Copy Markdown
Collaborator

@simone-silvestri do you mind taking a look at this validation? After we merge this I'd like your work in #5351 to it

Sorry was on vacation for a while. Looks good!

@tomchor tomchor merged commit 359f665 into main Mar 25, 2026
62 checks passed
@tomchor tomchor deleted the tc/add-open-hydro-validation branch March 25, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants