Merged
Conversation
navidcy
approved these changes
Mar 3, 2026
…A/Oceananigans.jl into ss/enable-partial-cell-conservation
briochemc
approved these changes
Mar 3, 2026
Collaborator
briochemc
left a comment
briochemc
left a comment
There was a problem hiding this comment.
This is great! Thanks @simone-silvestri !
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5356 +/- ##
==========================================
- Coverage 74.01% 73.97% -0.04%
==========================================
Files 400 400
Lines 22875 22869 -6
==========================================
- Hits 16930 16917 -13
- Misses 5945 5952 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR reenables conservation tests with zstar and
PartialCellBottomimmersed boundary grids. They seem to pass locally