(0.105.2) Fix with_halo for a TripolarGrid#5353
Merged
simone-silvestri merged 5 commits intomainfrom Mar 3, 2026
Merged
Conversation
navidcy
approved these changes
Mar 2, 2026
navidcy
changed the title
with_halo for a TripolarGridwith_halo for a TripolarGrid
navidcy
approved these changes
Mar 2, 2026
briochemc
added a commit
to briochemc/Oceananigans.jl
that referenced
this pull request
Mar 5, 2026
* glw/prescribed-free-surface: (0.105.3) Fix interpolation of terms in chain horizontal derivatives for MutableVerticalDiscretization (CliMA#5339) Fix ContinuousForcing field index mismatch in HydrostaticFreeSurfaceModel (CliMA#5370) Add dependency guardrail to Common Pitfalls (CliMA#5371) Fix typo SKR3 -> SRK3 (CliMA#5360) Add new reference to Zheng et al. (2025) in index (CliMA#5364) Add 9 missing papers to the reference list (CliMA#5363) Update papers section in index.md (CliMA#5362) Restructure AGENTS.md into multi-file agent configuration (CliMA#5350) (0.105.2) Fix `with_halo` for a `TripolarGrid` (CliMA#5353) (0.105.2) Fix and test checkpointing with open-domain simulations with a radiation `OpenBoundaryCondition` (CliMA#5347)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
at the moment, the
with_halofunction for aTripolarGridassumes we are constructing it with our custom tripolar constructor. This will not be the case for a tripolar grid we read from file, so we need to remove this assumption from thewith_halofunction (which is used in a SplitExplicitFreeSurface)