Avoid topology-aware operators when filling halos in the SplitExplicitFreeSurface#5332
Merged
simone-silvestri merged 6 commits intomainfrom Feb 24, 2026
Merged
Avoid topology-aware operators when filling halos in the SplitExplicitFreeSurface#5332simone-silvestri merged 6 commits intomainfrom
simone-silvestri merged 6 commits intomainfrom
Conversation
glwagner
reviewed
Feb 24, 2026
...s/HydrostaticFreeSurfaceModels/SplitExplicitFreeSurfaces/step_split_explicit_free_surface.jl
Outdated
Show resolved
Hide resolved
glwagner
approved these changes
Feb 24, 2026
Member
glwagner
left a comment
glwagner
left a comment
There was a problem hiding this comment.
you may want to use Val(true) / Val(false) to get compile-time selection of the operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we already have a "fill_halo" mode for the split explicit free surface. We can use that as a prototype to implement open boundary conditions since the literature review in #5229 showed that we need to fill the halos each substep.
However, at the moment, the split explicit evolution use topology-aware operators that automatically encode boundary conditions in the barotropic mode.
This PR chooses the operators to used based on if the halos are filled (then we can use normal operators) or not (we use topology-aware operators).
A little step to start supporting #5229
After this I will open a PR that slightly refactors the "fill halo mode" of the split explicit free surface to avoid distributed halos (
only_local_halos=true) and convert the necessary fill halo inputs to devices only once such that it will still be efficient (hopefully) even if we introduce open boundaries.