Skip to content

Fix undefined variable free_surface inside error message#5328

Merged
giordano merged 1 commit intomainfrom
mg/validate-free-surface-error
Feb 24, 2026
Merged

Fix undefined variable free_surface inside error message#5328
giordano merged 1 commit intomainfrom
mg/validate-free-surface-error

Conversation

@giordano
Copy link
Copy Markdown
Collaborator

Ref: #5225 (comment). Detected by JETLS.

@giordano giordano added the cleanup 🧹 Paying off technical debt label Feb 22, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.37%. Comparing base (1f0d6e7) to head (671c04c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...reeSurfaceModels/hydrostatic_free_surface_model.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5328      +/-   ##
==========================================
+ Coverage   68.75%   73.37%   +4.62%     
==========================================
  Files         398      398              
  Lines       21815    22550     +735     
==========================================
+ Hits        14999    16547    +1548     
+ Misses       6816     6003     -813     
Flag Coverage Δ
buildkite 68.70% <0.00%> (-0.06%) ⬇️
julia 68.70% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano giordano merged commit 1fdbb90 into main Feb 24, 2026
79 of 80 checks passed
@giordano giordano deleted the mg/validate-free-surface-error branch February 24, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup 🧹 Paying off technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants