Add DynamicSmagorinsky nonhydrostatic regression tests#5310
Conversation
…veraging) Tests will fail until regression truth data is generated and uploaded to OceananigansArtifacts.jl. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
cc @tomchor |
Regression truth data for DynamicSmagorinsky closure with both directional averaging and Lagrangian averaging. Each has checkpoints at iterations 10000 and 10010 (16³ grid, Δt=2, ocean LES setup). See CliMA/Oceananigans.jl#5310 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Regression truth data PR: glwagner/OceananigansArtifacts.jl#5 — needs to be merged to |
test/regression_tests/ocean_large_eddy_simulation_regression_test.jl
Outdated
Show resolved
Hide resolved
DynamicSmagorinsky is already exported from Oceananigans; only LagrangianAveraging needs an explicit import from TurbulenceClosures. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
+ Coverage 70.95% 73.25% +2.30%
==========================================
Files 389 397 +8
Lines 22287 22463 +176
==========================================
+ Hits 15813 16456 +643
+ Misses 6474 6007 -467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The Buildkite CI uses a persistent Julia depot, so the DataDeps cache for "regression_truth_data" from previous builds may not contain the newly added DynamicSmagorinsky regression files. This adds a check that clears and re-downloads the data if the expected files are missing. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
@tomchor can you fix the failing tests? |
Sure! I'll try to take a look at them later today when I have time |
|
@glwagner tests should be good now |
|
looks like they need to be restarted |
What do you mean? I see all tests passing, except the ones that aren't on Nautilus. Am I missing something? |
failing tests
|
Do you mean that I should restart the docker on nautilus? I think the failing tests aren't run on nautilus, right? |
|
dont worry @tomchor. I will restart the tests. |
|
looks like the tests passed after being restarted. I'll merge. |
|
Awesome! Thanks for this PR @glwagner |
|
also for future reference, in case not clear, "restarting the tests" is something that can be done within the PR (for gha you can close/reopen a PR, for buildkite you need to push an empty commit). In this case there was an update to main, so merging main triggered a re-build. Re-building with no additional commits is sometimes necessary for flaky CI. |
2 participants
Summary
DynamicSmagorinskyclosure with both directional averaging (averaging=(1, 2)) and Lagrangian averagingDynamicSmagorinskyvariantsTODO
data_for_regression_tests/Test plan
julia --project -e 'using Pkg; Pkg.test("Oceananigans", test_args=["nonhydrostatic_regression"])'🤖 Generated with Claude Code