Skip to content

Add support for OffsetArray in restore_prognostic_state! + minor variable name changes#5218

Merged
taimoorsohail merged 6 commits intomainfrom
ts/modify-restore-prognostic-state
Jan 30, 2026
Merged

Add support for OffsetArray in restore_prognostic_state! + minor variable name changes#5218
taimoorsohail merged 6 commits intomainfrom
ts/modify-restore-prognostic-state

Conversation

@taimoorsohail
Copy link
Copy Markdown
Collaborator

@taimoorsohail taimoorsohail commented Jan 28, 2026

Resolves #5212

@taimoorsohail taimoorsohail requested a review from navidcy January 28, 2026 01:49
glwagner
glwagner reviewed Jan 28, 2026
View reviewed changes
glwagner
glwagner reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good after I scanned it, though I am curious what @ali-ramadhan thinks.

Also @ali-ramadhan should we be restricting the second argument in restore_prognostic_state!? It seems like we often make assumptions about its properties, but the type is not provided. However it seems that @taimoorsohail has uncovered a case where the second type needs to be dispatched on?

@taimoorsohail
Copy link
Copy Markdown
Collaborator Author

taimoorsohail commented Jan 28, 2026

This PR seems to work for checkpointing distributed GPU NumericalEarth runs now, waiting for tests to pass

simone-silvestri
simone-silvestri reviewed Jan 28, 2026
View reviewed changes
@navidcy @simone-silvestri
Update src/Fields/field.jl
835b76c 
Co-authored-by: Simone Silvestri <[email protected]>
taimoorsohail
taimoorsohail commented Jan 28, 2026
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.91209% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.06%. Comparing base (d7b9a36) to head (fc28c44).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/OutputWriters/checkpointer.jl 83.33% 7 Missing ⚠️
src/OutputWriters/windowed_time_average.jl 62.50% 6 Missing ⚠️
...rostaticFreeSurfaceModels/explicit_free_surface.jl 0.00% 3 Missing ⚠️
src/Utils/schedules.jl 76.92% 3 Missing ⚠️
...rostaticFreeSurfaceModels/implicit_free_surface.jl 66.66% 1 Missing ⚠️
...gianParticleTracking/LagrangianParticleTracking.jl 66.66% 1 Missing ⚠️
src/Utils/multi_region_transformation.jl 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5218      +/-   ##
==========================================
- Coverage   73.07%   73.06%   -0.02%     
==========================================
  Files         394      394              
  Lines       21976    21981       +5     
==========================================
+ Hits        16060    16061       +1     
- Misses       5916     5920       +4
Flag Coverage Δ
buildkite 68.38% <94.11%> (+<0.01%) ⬆️
julia 68.38% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taimoorsohail taimoorsohail merged commit 85fd2cc into main Jan 30, 2026
78 checks passed
@taimoorsohail taimoorsohail deleted the ts/modify-restore-prognostic-state branch January 30, 2026 03:12
@tomchor tomchor mentioned this pull request Feb 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simone-silvestri simone-silvestri simone-silvestri left review comments

@glwagner glwagner glwagner approved these changes

@navidcy navidcy Awaiting requested review from navidcy

@ali-ramadhan ali-ramadhan Awaiting requested review from ali-ramadhan

Assignees

No one assigned

Labels

output 💾

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

restore_prognostic_state! not supported for OffsetArrays

4 participants

@taimoorsohail @navidcy @glwagner @simone-silvestri