Closed
Conversation
simone-silvestri
added
the
benchmark performance
navidcy
reviewed
Aug 14, 2025
benchmark/Manifest.toml
Outdated
Member
There was a problem hiding this comment.
do we need the Manifest? That would pin the Oceananigans version used, right?
Collaborator
Author
There was a problem hiding this comment.
yeah we probably don't need it. I can delete it. Oceananigans is added during the tests here
Member
|
Why don't we use the benchmark agent for this pipeline? That way it is guaranteed that only one benchmark runs at a time. |
Collaborator
Author
Right, this benchmark is run on the benchmark pipeline. |
giordano
reviewed
Oct 5, 2025
| command: | | ||
| # Instantiate | ||
| $TARTARUS_HOME/julia-$JULIA_VERSION/bin/julia --color=yes --project --check-bounds=no -e 'using Pkg; Pkg.add("CUDA"); Pkg.instantiate()' | ||
| $TARTARUS_HOME/julia-$JULIA_VERSION/bin/julia --color=yes --project=benchmark --check-bounds=no -e 'using Pkg; Pkg.add(path="./"); Pkg.instantiate()' |
Collaborator
There was a problem hiding this comment.
With Julia v1.11 you could use [sources] instead, but I see you're still on v1.10 for the time being
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
Collaborator
Author
|
I guess this PR is being superceded by #4882 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is here in preparation for #4706. It adds some unit benchmarks that will run on the CPU.
They have to be taken with a grain of salt since Tartarus might be occupied while running the benchmarks so the performance might show high variance. However it is good to have at least a pipeline for tests
Additionally, this PR revamps and fixes the
Benchmark.jlmodule to be used in the benchmark tests