I wouldn't call them unnecessary. Although it's not strictly enforced there is a mild preference to use const for local variables which are logically not meant to be mutated. That includes value args like a bare string_view. This isn't really an improvement imo

@akrieger I agree with part of what you said. According to Cpp Core Guidelines, local variables should be declared with const, but function parameters might be an exception.

To maintain consistency in the code style, most of the parameters passed by value in this project are not declared with const. This is to ensure uniformity and simplify the code.

std::string_view inherently contains an immutable reference to a string and is itself a simple pass-by-value parameter, so it should not be treated as an exception.

I'm aware that string_view does not allow mutating the viewed range but it is reassignable to view a different range. const std::string_view is like const char* const whereas std::string_view is const char*.

We don't explicitly follow any external style guides nor do we automatically consider their suggestions as meaningful to consider just because of the source. We have project local conventions we follow and consider each on a case by case basis.

This PR was simply made to maintain consistency with the code style of other parts of the same project. The Cpp Core Guidelines are just an example.