Skip to content

Conversation

@ShenMian
Copy link
Contributor

Summary

None

Purpose of change

Reduce potential unnecessary copies (temporary variables) and improve code consistency.
Additionally, refactor a nested if statements.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 18, 2025
@inogenous
Copy link
Contributor

You know, at work, we do java. And some of my colleagues, they keep asking me during code-review: "why do you insist on doing ++i instead of i++?". And I usually feel that pointing out how it makes a difference in c++ goes way above their heads, it's like they don't even consider the difference. So I'm so thankful for your change. Over here, we can do the subtle head-nod to each other, and we acknowledge that, yes, even the minor things matter.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 19, 2025
@GuardianDll GuardianDll merged commit b462d74 into CleverRaven:master Apr 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants