Replace const std::string_view & with std::string_view
#80611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
This avoids unnecessary reference passing.
There is no need to use
const std::string_view &, becausestd::string_viewitself is a reference to a string (std::stringorconst char*).Describe the solution
Although
const std::string_viewis closer to the original semantics, since it is a function parameter, omitting theconstmodifier here might be more appropriate.Although this change might have an impact on performance, even if it does, it would be negligible.
The main purpose is to simplify the code, so I filled in "None" in the Summary section.
Describe alternatives you've considered
Testing
This change will hardly affect the behavior of the code, so no testing is necessary.
Additional context