Skip to content

Fixed codeblocks being smaller than it actually is#98

Merged
NyxIsBad merged 2 commits intoClearVision:masterfrom
Endy3032:master
Apr 29, 2022
Merged

Fixed codeblocks being smaller than it actually is#98
NyxIsBad merged 2 commits intoClearVision:masterfrom
Endy3032:master

Conversation

@Endy3032
Copy link
Copy Markdown
Contributor

@Endy3032 Endy3032 commented Apr 28, 2022

Fixes #90

@Endy3032 Endy3032 requested a review from a team as a code owner April 28, 2022 12:08
@Endy3032 Endy3032 changed the title Fixed codeblocks smaller than it actually is Fixed codeblocks being smaller than it actually is Apr 28, 2022
@NyxIsBad
Copy link
Copy Markdown
Member

Thanks for doing the searching for me! I'm terribly sorry for being unable to address this earlier, I just kept forgetting about it and ghosting you (really my bad). I've run this locally and it seems not to cause any theme conflicts. For the sake of consistency, do you mind deleting the line entirely s.t. it looks like this?

// CODEBLOCK
  %codePre {
    padding: 0;
    background: transparent;
    border: 2px solid hsla(0, 0%, 100%, 0.05);
    border-radius: 8px;
    font-family: cv('font.code');
    & > %codeHLJS {

If so I'll approve and merge

@untuned
Copy link
Copy Markdown
Member

untuned commented Apr 29, 2022

Updated comment to auto close the attached issue when merged

@Endy3032
Copy link
Copy Markdown
Contributor Author

Thanks for doing the searching for me! I'm terribly sorry for being unable to address this earlier, I just kept forgetting about it and ghosting you (really my bad). I've run this locally and it seems not to cause any theme conflicts. For the sake of consistency, do you mind deleting the line entirely s.t. it looks like this?

// CODEBLOCK
  %codePre {
    padding: 0;
    background: transparent;
    border: 2px solid hsla(0, 0%, 100%, 0.05);
    border-radius: 8px;
    font-family: cv('font.code');
    & > %codeHLJS {

If so I'll approve and merge

Yeah no problem!

@Endy3032
Copy link
Copy Markdown
Contributor Author

do you mind deleting the line entirely s.t. it looks like this?

If so I'll approve and merge

Just got home and removed the line entirely just like you said

@NyxIsBad NyxIsBad merged commit d800171 into ClearVision:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Codeblock width in embed description is smaller than what its supposed to be

3 participants