Increase access token lifetime to 1 hour#474
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This pull request increases the JWT access token lifetime from 1 minute to 1 hour to improve user experience by reducing the frequency of token refreshes. The change is made in two locations to maintain consistency between the token generation logic and the API response.
Changes:
- Increased
AccessTokenLifetimeconstant from 1 minute to 1 hour inJwtService - Updated
ExpiresInfield in token response from 60 seconds to 3600 seconds to match the new lifetime
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| code/backend/Cleanuparr.Infrastructure/Features/Auth/JwtService.cs | Updated AccessTokenLifetime constant from 1 minute to 1 hour |
| code/backend/Cleanuparr.Api/Features/Auth/Controllers/AuthController.cs | Updated ExpiresIn field in TokenResponse from 60 to 3600 seconds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.