Fix the Download Cleaner page not displaying validation errors#472
Merged
Fix the Download Cleaner page not displaying validation errors#472
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes validation errors not displaying on the Download Cleaner settings page by adding error display capability to the accordion component and implementing a validation check to ensure at least one feature (Seeding rules or Unlinked Downloads) is configured when the download cleaner is enabled.
Changes:
- Added error input and display to the AccordionComponent to show validation errors in accordion headers
- Added
noFeaturesErrorcomputed property to validate that at least one feature is configured - Improved error handling in save method to display specific API error messages for 400 status codes
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| code/frontend/src/app/ui/accordion/accordion.component.ts | Added optional error input property to accept error messages |
| code/frontend/src/app/ui/accordion/accordion.component.scss | Added styling for error display with error color and proper spacing |
| code/frontend/src/app/ui/accordion/accordion.component.html | Added conditional error message display in accordion header |
| code/frontend/src/app/features/settings/download-cleaner/download-cleaner.component.ts | Added noFeaturesError validation, integrated into hasErrors, imported ApiError for typed error handling, and improved error message display for 400 status codes |
| code/frontend/src/app/features/settings/download-cleaner/download-cleaner.component.html | Bound noFeaturesError() to both accordion components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
code/frontend/src/app/features/settings/download-cleaner/download-cleaner.component.html
Show resolved
Hide resolved
code/frontend/src/app/features/settings/download-cleaner/download-cleaner.component.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.