Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This pull request adds rTorrent/ruTorrent support to Cleanuparr, implementing a new download client option alongside the existing qBittorrent, Deluge, Transmission, and µTorrent clients. The implementation includes a custom XML-RPC client for communicating with rTorrent since it doesn't have a native .NET library.
Changes:
- Added complete rTorrent client implementation with XML-RPC communication layer
- Refactored
DeleteDownloadmethod signature across all download clients from hash-based to object-based deletion - Added
SavePathproperty toITorrentItemWrapperinterface for file path resolution - Updated frontend UI to support rTorrent-specific configuration (authentication, URL base hints)
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/configuration/download-client/index.mdx | Added rTorrent to supported clients list and documented XML-RPC endpoint configuration |
| code/frontend/src/app/shared/models/enums.ts | Added rTorrent enum value to DownloadClientTypeName |
| code/frontend/src/app/features/settings/download-clients/download-clients.component.ts | Added UI logic to hide username/password fields for rTorrent and set default URL base |
| code/frontend/src/app/features/settings/download-clients/download-clients.component.html | Conditionally show/hide password field based on client type |
| code/backend/Cleanuparr.Domain/Enums/DownloadClientTypeName.cs | Added rTorrent to backend enum |
| code/backend/Cleanuparr.Domain/Entities/RTorrent/Response/*.cs | Defined RTorrentTorrent and RTorrentFile response entities |
| code/backend/Cleanuparr.Domain/Exceptions/RTorrentClientException.cs | Custom exception for rTorrent client errors |
| code/backend/Cleanuparr.Domain/Entities/ITorrentItemWrapper.cs | Added SavePath property to interface |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/RTorrent/*.cs | Complete rTorrent service implementation including XML-RPC client, service logic, and wrapper classes |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/IDownloadService.cs | Changed DeleteDownload signature to accept ITorrentItemWrapper instead of hash |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/DownloadService.cs | Added TryDeleteFiles helper method and updated DeleteDownload method signature |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/*/.*ItemWrapper.cs | Added SavePath property implementations (some throw NotImplementedException) |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/Service.cs | Updated DeleteDownload implementations for all clients |
| code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/DownloadServiceFactory.cs | Added factory method for creating RTorrentService instances |
| code/backend/Cleanuparr.Api/DependencyInjection/MainDI.cs | Changed MassTransit concurrent message limits from 2 to 1 |
| code/backend/Cleanuparr.Infrastructure.Tests/Features/DownloadClient/RTorrent*.cs | Comprehensive test suite for rTorrent functionality |
| code/backend/Cleanuparr.Infrastructure.Tests/Features/DownloadClient/*ServiceDCTests.cs | Updated tests to use new DeleteDownload signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/DownloadService.cs
Outdated
Show resolved
Hide resolved
code/backend/Cleanuparr.Infrastructure.Tests/Features/DownloadClient/RTorrentServiceDCTests.cs
Show resolved
Hide resolved
code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/QBittorrent/QBitItemWrapper.cs
Outdated
Show resolved
Hide resolved
...nd/Cleanuparr.Infrastructure/Features/DownloadClient/Transmission/TransmissionItemWrapper.cs
Outdated
Show resolved
Hide resolved
code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/Deluge/DelugeItemWrapper.cs
Outdated
Show resolved
Hide resolved
code/frontend/src/app/features/settings/download-clients/download-clients.component.ts
Show resolved
Hide resolved
code/frontend/src/app/features/settings/download-clients/download-clients.component.ts
Show resolved
Hide resolved
code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/RTorrent/RTorrentServiceDC.cs
Show resolved
Hide resolved
code/backend/Cleanuparr.Infrastructure/Features/DownloadClient/UTorrent/UTorrentItemWrapper.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #180