Fix failed import reason display for events#443
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the Events UI so event data values that are objects/arrays are rendered as readable JSON instead of "[object Object]", addressing issue #439 in the event log details view.
Changes:
- Add a
formatValue()helper to stringify object-like values for display. - Update the event data rendering in the template to use the new formatter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
code/frontend/src/app/features/events/events.component.ts |
Adds formatValue() to convert object/array values into JSON strings for display. |
code/frontend/src/app/features/events/events.component.html |
Uses formatValue() when rendering event.data key/value pairs to avoid "[object Object]". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Flaminel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #439