Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Fixes download-client configuration input handling so URLs with embedded HTTP auth credentials and saved passwords round-trip correctly (relates to #441).
Changes:
- Preserve exact
Uriinput strings in EF Core (including embedded credentials) via a custom converter/comparer. - Change download-client request contracts to accept
Host/ExternalUrlas strings and parse them intoUri. - Populate the edit modal’s password field from the existing client config.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| code/frontend/src/app/features/settings/download-clients/download-clients.component.ts | Pre-fills modal password when editing an existing client. |
| code/backend/Cleanuparr.Persistence/DataContext.cs | Adds global Uri value converter/comparer to store OriginalString in the DB. |
| code/backend/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/UpdateDownloadClientRequest.cs | Switches Host/ExternalUrl to string inputs and parses to Uri on apply. |
| code/backend/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/TestDownloadClientRequest.cs | Switches Host to string input and parses to Uri for test config. |
| code/backend/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/CreateDownloadClientRequest.cs | Switches Host/ExternalUrl to string inputs and parses to Uri on create. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...end/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/CreateDownloadClientRequest.cs
Show resolved
Hide resolved
...end/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/UpdateDownloadClientRequest.cs
Show resolved
Hide resolved
...ckend/Cleanuparr.Api/Features/DownloadClient/Contracts/Requests/TestDownloadClientRequest.cs
Show resolved
Hide resolved
code/frontend/src/app/features/settings/download-clients/download-clients.component.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #441