Improved Mod List Version Check Edtion#321
Merged
Rongmario merged 8 commits intoCleanroomMC:experimental/foundationfrom Apr 4, 2025
Desoroxxx:improve-mod-list-3-revenge-of-the-versioncheck
Merged
Improved Mod List Version Check Edtion#321Rongmario merged 8 commits intoCleanroomMC:experimental/foundationfrom Desoroxxx:improve-mod-list-3-revenge-of-the-versioncheck
Rongmario merged 8 commits intoCleanroomMC:experimental/foundationfrom
Desoroxxx:improve-mod-list-3-revenge-of-the-versioncheck
Conversation
Rongmario
requested changes
Apr 4, 2025
Member
Rongmario
left a comment
Rongmario
left a comment
There was a problem hiding this comment.
Looks great, just some minor changes,
Rongmario
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This once agains improve the mod list.
Firstly here are the bug fixes in this PR:
Now there is a minor tweak, the mod list now uses the Minecraft red color (0x993333) for disabled mods instead of a random red.
The real big change here is the new visualization for different version check states, this was already partially implemented (most code change is to "push it to the finish line", but it could have been tiny in terms of changes).
Here is how it looks like:
Also the main menu blinking indicator while switching between the beta update blink and the release blink depending on update availability, sadly, it is hard to show here in screenshots