Improved mod-list#313
Merged
kappa-maintainer merged 2 commits intoCleanroomMC:mainfrom Mar 31, 2025
Desoroxxx:improved-mod-list
Merged
Improved mod-list#313kappa-maintainer merged 2 commits intoCleanroomMC:mainfrom Desoroxxx:improved-mod-list
kappa-maintainer merged 2 commits intoCleanroomMC:mainfrom
Desoroxxx:improved-mod-list
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple and small PR aims at improving the mod-list.
This mainly removes the redundant third line in the modlist, here is what it could show and why it was redundant:
DISABLEDif the mod is disabled, redundant because the text is already red and the button supposedly is toggledMetadata not foundI have never seen this, and I’m not sure why you would want it there, but it exists for a null check of the next oneX child modsorNo child modsthis is redundant as well because the "details pane" already shows the number of child mods and their infoRemoving this line makes the mod-list a third smaller while not removing any information, which I think is a welcomed improvement.
It also adds the fade overlay at the bottom and top of the list found in every similar GUI in the game, it is a simple copy paste, but nice for consistency.
While this is a small PR I would be willing to extend it further if any doable ideas arise.