Conversation
After the SimplePie library was updated to version `1.8.0` in https://core.trac.wordpress.org/changeset/59141, an edge case has been discovered where a fatal error can encountered if the `blog_charset` option is missing or empty. In `fetch_feed()`, this option is retrieved using `get_option()` instead of `get_bloginfo( ‘charset’ )`. The latter will detect this scenario and apply a default value of `UTF-8` and is already used interchangeably throughout Core. This switches to `get_bloginfo( ‘charset’ )` instead to prevent this edge case. WP:Props david.binda, davidbaumwald, SergeyBiryukov, sabernhardt, azaozz, peterwilsoncc. Fixes https://core.trac.wordpress.org/ticket/62354. --- Merges https://core.trac.wordpress.org/changeset/59382 / WordPress/wordpress-develop@2762e5e92b to ClassicPress.
Introduced a new test data file containing the WordPress.org news RSS feed in XML format for use in PHPUnit tests.
Includes correcting the test class name as per the naming conventions. Follow-up to https://core.trac.wordpress.org/changeset/59382. See https://core.trac.wordpress.org/ticket/62280. --- Merges https://core.trac.wordpress.org/changeset/59408 / WordPress/wordpress-develop@a731b9bfc0 to ClassicPress.
Upgrades the Simple Pie library to a patched version of [https://github.com/simplepie/simplepie/releases/tag/1.8.1 Simple Pie 1.8.1]. Much of 1.8.1 was included in the 1.8.0 upgrade committed in r59141. The following fixes from the latest release those that remain for this upgrade: * Fix locator with website missing `Content-Type` header [simplepie/simplepie#891 simplepie/simplepiehttps://core.trac.wordpress.org/ticket/891] * Fix `encode` argument of `SimplePie::strip_htmltags()` [simplepie/simplepie#894 simplepie/simplepiehttps://core.trac.wordpress.org/ticket/894] A caching fix not included in Simple Pie 1.8.1 is also included in this upgrade, see [simplepie/simplepie#883 simplepie/simplepiehttps://core.trac.wordpress.org/ticket/883]. A caching test for `fetch_feed()` is introduced in this pull request to ensure that the caching patch is included in future upgrades of the library. WP:Props kaygee79, oglekler, SergeyBiryukov, peterwilsoncc. Fixes https://core.trac.wordpress.org/ticket/63717. --- Merges https://core.trac.wordpress.org/changeset/60490 / WordPress/wordpress-develop@f0a3c68f9e to ClassicPress.
…n 1.9.0. References: * [https://github.com/simplepie/simplepie/releases/tag/1.9.0 SimplePie 1.9.0 release notes] * [simplepie/simplepie@1.8.1...1.9.0 Full list of changes in SimplePie 1.9.0] Follow-up to https://core.trac.wordpress.org/changeset/59141, https://core.trac.wordpress.org/changeset/60490. WP:Props swissspidy, TobiasBg, SergeyBiryukov. Fixes https://core.trac.wordpress.org/ticket/63961. Conflicts: - src/wp-includes/feed.php --- Merges https://core.trac.wordpress.org/changeset/60771 / WordPress/wordpress-develop@2553772fb0 to ClassicPress.
Cleaned up leftover merge conflict markers and redundant code in fetch_feed function to ensure proper sanitization class is set for SimplePie.
…mplePie. After the update to v1.9.0 in https://core.trac.wordpress.org/changeset/60771, this merges a single bug fix, in absence of a new upstream release in time for 6.9 Beta. References: * [simplepie/simplepie#949 Original upstream PR] WP:Props swissspidy. Fixes https://core.trac.wordpress.org/ticket/63961. --- Merges https://core.trac.wordpress.org/changeset/60947 / WordPress/wordpress-develop@330deca538 to ClassicPress.
Added 'wp-includes/SimplePie/src/Decode' and 'wp-includes/SimplePie/src/Core.php' to the $_old_files array to support the upgrade to SimplePie 1.9.0.
xxsimoxx
approved these changes
Dec 4, 2025
Member
xxsimoxx
left a comment
xxsimoxx
left a comment
There was a problem hiding this comment.
LGTM. Local unit tests are passing after grunt build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade SimplePie to version 1.9.0 and also apply a PHP 8.5 fix that is as yet unrelease.
This is a sequential PR backporting five previous updates and changes, incluiding removing files removed from SimplePie on upgrade..
Motivation and context
PHP 8.5 compatibility and extrnal library upgrade.
How has this been tested?
This is a sequentila backport, local test suite (PHPUnit and PCPCS) are passing, but will also run on this PR.
Screenshots
N/A
Types of changes